-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluid typography: pass theme.json settings to override merged theme data #6477
Fluid typography: pass theme.json settings to override merged theme data #6477
Conversation
Fluid typography: pass theme.json settings to override merged theme data
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM!
Committed in r58171. |
This commit updates failing tests caused by merge
Trac ticket: https://core.trac.wordpress.org/ticket/61118
Updates the second argument of wp_get_typography_font_size_value() to be a theme_json settings array.
Add a backwards compatibility condition to handle booleans.
Syncs:
The changes:
Why?
To generate a stylesheet, theme.json settings are often passed directly to WP_Theme_JSON.
Because typography block supports looks at the global settings only, the font sizes and CSS vars will have a clamp() value in the returned stylesheet if the current theme has fluid typography activated.
Passing theme.json settings to gutenberg_get_typography_font_size_value() as the second argument allows users of the class interface to provide their own settings, which will override any global theme settings.
See Gutenberg bug report: WordPress/gutenberg#58135