Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added @global to PHP Docs Comments #59725

Merged
merged 2 commits into from
Mar 9, 2024
Merged

Added @global to PHP Docs Comments #59725

merged 2 commits into from
Mar 9, 2024

Conversation

shail-mehta
Copy link
Member

@shail-mehta shail-mehta commented Mar 9, 2024 •
edited
Loading

  • Added @global in php docs comments
  • Added @since before @param & @return according to PHP Doc Standards

Fixes: #59724

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <shailu25@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta shail-mehta mentioned this pull request Mar 9, 2024
Closed
t-hamano
t-hamano requested changes Mar 9, 2024
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think there needs to be a change regarding periods, but I think this change makes sense.

lib/client-assets.php Outdated Show resolved Hide resolved
lib/compat/wordpress-6.5/scripts-modules.php Outdated Show resolved Hide resolved
@t-hamano t-hamano added the [Type] Code Quality Issues or PRs that relate to code quality label Mar 9, 2024
@t-hamano
Copy link
Contributor

t-hamano commented Mar 9, 2024

Note: Core already adds the @global annotation, so no backport is needed.

@shail-mehta shail-mehta requested a review from t-hamano March 9, 2024 09:12
t-hamano
t-hamano approved these changes Mar 9, 2024
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@t-hamano t-hamano merged commit 3b42812 into WordPress:trunk Mar 9, 2024
57 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.0 milestone Mar 9, 2024
@shail-mehta shail-mehta deleted the add-global-to-php-docs branch April 7, 2024 05:25
@ellatrix ellatrix mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees
No one assigned
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shail-mehta @t-hamano