Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix responsive column span logic on the front end. #60976

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

tellthemachines
Copy link
Contributor

What?

Fixes issue detected here where grid elements spanning multiple columns weren't correctly downsizing when the parent grid's minimumColumnWidth was a non-default value.

Testing Instructions

  1. Add a Grid block to a post or template, and add some children to it.
  2. Adjust the column span values on some of the children so they cover multiple columns.
  3. Save, publish and view on the front end. Resize browser window and check that multi-column elements reflow nicely.

Testing Instructions for Keyboard

Screenshots or screencast

This should be the expected behaviour for the example given in the original report:

grid-resize.mp4

@tellthemachines tellthemachines added [Type] Bug An existing feature does not function as intended [Feature] Layout Layout block support, its UI controls, and style output. labels Apr 23, 2024
@tellthemachines tellthemachines self-assigned this Apr 23, 2024
Copy link

github-actions bot commented Apr 23, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected :)

@tellthemachines tellthemachines merged commit 3d9bdee into trunk Apr 23, 2024
68 checks passed
@tellthemachines tellthemachines deleted the fix/colspan-responsive branch April 23, 2024 06:19
@github-actions github-actions bot added this to the Gutenberg 18.3 milestone Apr 23, 2024
@tellthemachines tellthemachines added the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Apr 23, 2024
@tellthemachines
Copy link
Contributor Author

Adding backport label so this fix can hopefully go into 18.2! Cc @colorful-tones

@colorful-tones
Copy link
Member

colorful-tones commented Apr 23, 2024

Thanks for the heads up @tellthemachines. I'll do my best and follow the notes to cherry-pick this in, and of course, ask questions if I hit a snag. 👍

@colorful-tones
Copy link
Member

I just cherry-picked this PR to the release/18.2 branch to get it included in the next release: fd37383

colorful-tones pushed a commit that referenced this pull request Apr 24, 2024
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
@colorful-tones colorful-tones removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Apr 24, 2024
@tellthemachines tellthemachines added the Needs PHP backport Needs PHP backport to Core label Apr 30, 2024
@tellthemachines tellthemachines removed the Needs PHP backport Needs PHP backport to Core label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Layout Layout block support, its UI controls, and style output. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants