Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Backport: Add excerpt support to the wp_block post type #6579

Conversation

carolinan
Copy link
Contributor

Trac ticket: https://core.trac.wordpress.org/ticket/61250

Add excerpt to the list of supports when registering the wp_block post type.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Add excerpt to the list of supports when registering the wp_block post type.
Copy link

github-actions bot commented May 20, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props poena, krupalpanchal, ntsekouras.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link

@krupal-panchal krupal-panchal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ntsekouras ntsekouras requested review from audrasjb and ellatrix May 22, 2024 18:10
@ntsekouras
Copy link

Thanks @carolinan! It seems the failures are valid since the excerpt is returned in the API response.

@carolinan
Copy link
Contributor Author

Thanks @carolinan! It seems the failures are valid since the excerpt is returned in the API response.

I don't know what that means, who can help fix it?

@ntsekouras
Copy link

I don't know what that means, who can help fix it?

I'm not excerpt here, but I tried this:

  1. In your branch start the dev environment npm run env:start
  2. Run the php tests npm run test:php
  3. Just by running the tests, my tests/qunit/fixtures/wp-api-generated.js file got updated with the excerpt info in wp/v2/blocks endpoint.

Can you try the above and then push the changes from the generated file? I believe this should be enough, but if this doesn't work, let's ping some more folks 😄

The updated fixture was generated by running ´npm run test:php´
Copy link

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thank you!

@SergeyBiryukov
Copy link
Member

Thanks for the PR! Merged in r58184.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants