-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP Backport: Add excerpt support to the wp_block post type #6579
PHP Backport: Add excerpt support to the wp_block post type #6579
Conversation
Add excerpt to the list of supports when registering the wp_block post type.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @carolinan! It seems the failures are valid since the excerpt is returned in the API response. |
I don't know what that means, who can help fix it? |
I'm not excerpt here, but I tried this:
Can you try the above and then push the changes from the generated file? I believe this should be enough, but if this doesn't work, let's ping some more folks 😄 |
The updated fixture was generated by running ´npm run test:php´
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Thank you!
Thanks for the PR! Merged in r58184. |
Trac ticket: https://core.trac.wordpress.org/ticket/61250
Add excerpt to the list of supports when registering the wp_block post type.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.