-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Options: Add 'label' argument to register_setting #6495
Conversation
@@ -237,6 +237,7 @@ protected function get_registered_options() { | |||
|
|||
$default_schema = array( | |||
'type' => empty( $args['type'] ) ? null : $args['type'], | |||
'label' => empty( $args['label'] ) ? '' : $args['label'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TimothyBJacobs, in Gutenberg shim, we used the title
key for the schema. Would it make sense to have a direct mapping to the argument here, or is the title
key reserved for similar data in schemas?
Gutenberg PR: WordPress/gutenberg#59243
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it should be title
as the prop name. That is how it's defined in the JSON Schema spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification!
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
3eab7d7
to
04d1a06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The wp-api-generated.js
file will need to be rebuilt before committing.
Thanks for the review, @TimothyBJacobs 🙇
I always forget about it. I wish there was a pre-commit hook for it. To update it, I need to run a full PHP test suite, correct? Running the following command did the trick - |
Yeah the process is a bit frustrating. Was GB active on your checkout? |
No. I've got a separate installation just for core patches. Edit: I updated fixtures again by running the whole test suite, and it worked. |
@Mamaduka Is this good to merge? |
@ellatrix, yes, it's good to be merged. |
Could you merge it? |
Should WordPress/gutenberg#61351 be included here or in a separate backport? |
A sync ticket for WordPress/gutenberg#59243.
Trac ticket: https://core.trac.wordpress.org/ticket/61023
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.