fix: support the character sequence 'sku' in product SKUs #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
force-pushed
the
bugfix/sku_in_productSKU
branch
from
e781f36 to
3d87ea3
Compare
|
Fixed and put in a workaround so slugs don't contain the term |
* add integration test for routing * allow sku in sku * allow sku in category * assure no -cat in slugs
shauke
force-pushed
the
bugfix/sku_in_productSKU
branch
from
91622c0 to
50005e9
Compare
SGrueber
pushed a commit
that referenced
this pull request
May 19, 2022
* add integration test for routing * allow sku in sku * allow sku in category * assure no -cat in slugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
The current
product.routematcher results in an error page if the products SKU contains the character sequenceskue.g.glaskugel_1.Example product detail URL:
http://localhost:4200/Acer/Glaskugel-skuglaskugel_1-catComputers.897.897_AcerResults in a wrong REST API call for the product details:
https://pwa-ish-demo.test.intershop.com/INTERSHOP/rest/WFS/inSPIRED-inTRONICS_Business-Site/rest;loc=en_US;cur=USD/products/gel_1?allImages=trueskuglaskugel_1
What Is the New Behavior?
Routes with product SKUs containing the character sequence
skuwork as expected.Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#72230