chore: add rule for meaningful top-level describes in tests #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
added
regression
MaxKless
previously approved these changes
Mar 22, 2022
dhhyi
force-pushed
the
chore/meaningful-describe-in-tests
branch
from
e116e53 to
b987be9
Compare
MaxKless
approved these changes
Mar 22, 2022
SGrueber
pushed a commit
that referenced
this pull request
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the Current Behavior?
Top-level describes in tests are no longer corrected after the TSLint-> ESLint migration. This can lead to confusing test outputs if a new test has an wrong name due to refactoring or copy&paste.
What Is the New Behavior?
New rule to assert the old behavior.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#75398