-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: compile schematics into a dist folder #1084
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
added
refactoring
Refactoring of current code
community
Community contributions
labels
Mar 24, 2022
Please merge #1078 first |
dhhyi
force-pushed
the
refactor/schematics-schema-generation
branch
from
March 25, 2022 10:48
64fd4da
to
5a093c0
Compare
dhhyi
force-pushed
the
refactor/schematics-dist-folder
branch
from
March 25, 2022 11:23
6c6994d
to
f291218
Compare
Base automatically changed from
refactor/schematics-schema-generation
to
develop
March 29, 2022 15:09
MaxKless
force-pushed
the
refactor/schematics-dist-folder
branch
from
March 29, 2022 15:37
f291218
to
020d98e
Compare
MaxKless
reviewed
Mar 30, 2022
dhhyi
force-pushed
the
refactor/schematics-dist-folder
branch
from
March 30, 2022 10:43
e69179c
to
3411734
Compare
MaxKless
approved these changes
Mar 30, 2022
SGrueber
pushed a commit
that referenced
this pull request
May 19, 2022
Co-authored-by: max.kless@googlemail.com <max.kless@googlemail.com>
I have a question, why you've changed the imports in the Now: import { switchMap } from '@angular-devkit/core/node_modules/rxjs/operators'; Before: import { switchMap } from 'rxjs/operators'; ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Refactoring (no functional changes, no API changes)
[x] Build-related changes
What Is the Current Behavior?
Generated sources in schematics cluttered into source folder.
What Is the New Behavior?
A dedicated dist folder is used.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#75593