Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: compile schematics into a dist folder #1084

Merged
merged 3 commits into from
Mar 30, 2022

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Mar 24, 2022

PR Type

[x] Refactoring (no functional changes, no API changes)
[x] Build-related changes

What Is the Current Behavior?

Generated sources in schematics cluttered into source folder.

What Is the New Behavior?

A dedicated dist folder is used.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#75593

@dhhyi dhhyi added refactoring Refactoring of current code community Community contributions labels Mar 24, 2022
@dhhyi dhhyi self-assigned this Mar 24, 2022
@dhhyi dhhyi requested a review from MaxKless March 24, 2022 13:39
@dhhyi dhhyi added the wait Waiting for something (e.g. new ICM release) label Mar 24, 2022
@dhhyi dhhyi marked this pull request as ready for review March 24, 2022 13:39
@dhhyi
Copy link
Collaborator Author

dhhyi commented Mar 24, 2022

Please merge #1078 first

@dhhyi dhhyi removed their assignment Mar 24, 2022
@dhhyi dhhyi force-pushed the refactor/schematics-schema-generation branch from 64fd4da to 5a093c0 Compare March 25, 2022 10:48
@dhhyi dhhyi force-pushed the refactor/schematics-dist-folder branch from 6c6994d to f291218 Compare March 25, 2022 11:23
@MaxKless MaxKless self-assigned this Mar 28, 2022
Base automatically changed from refactor/schematics-schema-generation to develop March 29, 2022 15:09
@MaxKless MaxKless force-pushed the refactor/schematics-dist-folder branch from f291218 to 020d98e Compare March 29, 2022 15:37
@dhhyi dhhyi removed the wait Waiting for something (e.g. new ICM release) label Mar 29, 2022
@dhhyi dhhyi force-pushed the refactor/schematics-dist-folder branch from e69179c to 3411734 Compare March 30, 2022 10:43
@MaxKless MaxKless merged commit a827476 into develop Mar 30, 2022
@MaxKless MaxKless deleted the refactor/schematics-dist-folder branch March 30, 2022 12:14
SGrueber pushed a commit that referenced this pull request May 19, 2022
Co-authored-by: max.kless@googlemail.com <max.kless@googlemail.com>
@kepek
Copy link
Contributor

kepek commented Feb 23, 2023

I have a question, why you've changed the imports in the factory_spec.ts files? For example: https://github.com/intershop/intershop-pwa/pull/1084/files#diff-521c8ae65a91cceddb8c9833aa8929d737db387cc822cd4df0ee3291dce042be

Now:

import { switchMap } from '@angular-devkit/core/node_modules/rxjs/operators';

Before:

import { switchMap } from 'rxjs/operators';

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contributions refactoring Refactoring of current code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants