refactor: compare as extension #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
added
refactoring
dhhyi
force-pushed
the
refactor/compare-as-extension
branch
2 times, most recently
from
c54f288 to
634b97d
Compare
dhhyi
force-pushed
the
refactor/compare-as-extension
branch
3 times, most recently
from
54cd5ce to
3b14c5b
Compare
dhhyi
force-pushed
the
refactor/compare-as-extension
branch
from
3b14c5b to
e92397a
Compare
SGrueber
previously approved these changes
Mar 31, 2022
shauke
force-pushed
the
refactor/compare-as-extension
branch
from
56fc4be to
0f0f2ca
Compare
SGrueber
pushed a commit
that referenced
this pull request
May 19, 2022
BREAKING CHANGES: The compare functionality was moved into an extension (see [Migrations / 2.1 to 2.2](https://github.com/intershop/intershop-pwa/blob/develop/docs/guides/migrations.md#21-to-22) for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Refactoring (no functional changes, no API changes)
What Is the Current Behavior?
Compare functionality is already a feature toggle, but not an extension.
What Is the New Behavior?
Refactored to an extension.
Does this PR Introduce a Breaking Change?
[ ] Yes
[ ] No
Other Information