-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: provide reusable formly configs #1017
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxKless
added
enhancement
Enhancement to an existing feature
refactoring
Refactoring of current code
labels
Feb 15, 2022
MaxKless
force-pushed
the
refactor/reusable-formly-configs
branch
3 times, most recently
from
February 22, 2022 10:08
41d1051
to
4cfd1eb
Compare
MaxKless
force-pushed
the
refactor/reusable-formly-configs
branch
3 times, most recently
from
February 24, 2022 10:07
ede45f5
to
f1108e5
Compare
MaxKless
force-pushed
the
refactor/reusable-formly-configs
branch
from
February 25, 2022 13:04
f1108e5
to
021dc92
Compare
SGrueber
requested changes
Mar 2, 2022
MaxKless
force-pushed
the
refactor/reusable-formly-configs
branch
from
March 2, 2022 17:08
7d6174a
to
f7fb0a7
Compare
SGrueber
force-pushed
the
refactor/reusable-formly-configs
branch
4 times, most recently
from
March 30, 2022 13:15
f61350b
to
11b7239
Compare
MaxKless
force-pushed
the
refactor/reusable-formly-configs
branch
from
March 30, 2022 15:05
11b7239
to
f036f9f
Compare
SGrueber
force-pushed
the
refactor/reusable-formly-configs
branch
from
March 31, 2022 11:08
f036f9f
to
e2204ce
Compare
SGrueber
previously approved these changes
Mar 31, 2022
MaxKless
added a commit
that referenced
this pull request
Mar 31, 2022
MaxKless
added a commit
that referenced
this pull request
Mar 31, 2022
MaxKless
force-pushed
the
refactor/reusable-formly-configs
branch
from
March 31, 2022 11:20
e2204ce
to
f657de7
Compare
MaxKless
force-pushed
the
refactor/reusable-formly-configs
branch
from
March 31, 2022 11:29
f657de7
to
35723fd
Compare
MaxKless
added a commit
that referenced
this pull request
Mar 31, 2022
SGrueber
pushed a commit
that referenced
this pull request
May 19, 2022
SGrueber
pushed a commit
that referenced
this pull request
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Currently, the PWA code contains many repetitions of the same formly field configurations. For example, the
firstName
field is present in the registration page, each address form and the account page. This can lead to some inconsistencies (see #997) and to lots of repetition when adjusting a field configuration.What Is the New Behavior?
This PR attempts to solve this problem by introducing a central point of contact for interacting with reusable field configurations, the aptly named
reusable-formly-field-configurations.service.ts
(name WIP 😸).It can read a list of predefined configurations and then lets you retrieve a field configuration service by id (for example
firstName
) anywhere you inject the service. This leads to less repetition.ToDo
Central point of customization via transform method in service or extension that does the same?write schematic for adding a new shortcut.configuration.ts
filesextension for field groups?Does this PR Introduce a Breaking Change?
[x] Yes
[ ] No
Other Information
AB#74369