feat(eslint): rules for customization #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
added a commit
that referenced
this pull request
Mar 9, 2022
dhhyi
force-pushed
the
feat/lint-rules-for-customization
branch
3 times, most recently
from
7053461 to
8dfd9e2
Compare
dhhyi
added
community
dhhyi
added a commit
that referenced
this pull request
Mar 10, 2022
dhhyi
force-pushed
the
feat/lint-rules-for-customization
branch
from
8dfd9e2 to
a885582
Compare
dhhyi
force-pushed
the
feat/lint-rules-for-customization
branch
from
a885582 to
42f37f5
Compare
MaxKless
approved these changes
Mar 22, 2022
SGrueber
pushed a commit
that referenced
this pull request
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
[x] Other: Best Practice
What Is the Current Behavior?
When using the Intershop PWA with multiple themes, some best practices should be honored:
THEMEvariable should not be used in components, instead component file overrides should be usedtemplateUrlandstyleUrlsshould always point to the base file, so the override mechanism can step in at build time.What Is the New Behavior?
Lint rules added.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
AB#75105