Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor cleanup testbed improvements #1076

Merged
merged 5 commits into from
Mar 22, 2022
Merged

chore: minor cleanup testbed improvements #1076

merged 5 commits into from
Mar 22, 2022

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Mar 22, 2022 •
edited
Loading

PR Type

[x] Bugfix

What Is the Current Behavior?

When cleanup-testbed is run in CI, it will try to execute against eslint rules specs, but ignores the file in the individual run:

> node scripts/cleanup-testbed.mjs "origin/develop"

found 6 test files
did not find any test files <-- that one is a eslint test
at src/app/core/store/shopping/product-prices/product-prices.effects.spec.ts 3 tests
...

Execution for folders and multiple files on powershell does not work

What Is the New Behavior?

  • Minimatch is used to filter out potential files from git diff checks.
  • ordered-imports check and pre-commit check for .mjs files.
  • normalizing paths to work with windows cmd and powershell

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#75414

@dhhyi dhhyi added bug:minor community Community contributions labels Mar 22, 2022
@dhhyi dhhyi requested a review from shauke March 22, 2022 11:16
@dhhyi dhhyi marked this pull request as draft March 22, 2022 11:21
@dhhyi dhhyi force-pushed the chore/cleanup-testbed-improvements branch from 1a5df9a to 73de734 Compare March 22, 2022 12:32
@dhhyi dhhyi marked this pull request as ready for review March 22, 2022 13:20
@shauke shauke added this to the 2.2 milestone Mar 22, 2022
@shauke shauke merged commit 75bff45 into develop Mar 22, 2022
@shauke shauke deleted the chore/cleanup-testbed-improvements branch March 22, 2022 14:22
SGrueber pushed a commit that referenced this pull request May 19, 2022
@dhhyi @SGrueber
chore: minor cleanup testbed improvements (#1076)
7f3170e 
* chore: activate ordered imports for mjs files
* chore: activate pre-commit lint for mjs files
* refactor: use minimatch for filtering files
* refactor: handle help first
* fix: support folder and multi-file command for win
SGrueber pushed a commit that referenced this pull request May 19, 2022
Merged PR 1287: Update poc Sales solution to pwa 2.2
a346ab7 
Related work items: #963, #1017, #1030, #1046, #1048, #1051, #1053, #1054, #1055, #1056, #1057, #1058, #1061, #1067, #1069, #1072, #1074, #1075, #1076, #1077, #1078, #1079, #1082, #1083, #1084, #1085, #1086, #1090, #1093, #1095, #1096, #1099, #1101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shauke shauke shauke approved these changes

Assignees
No one assigned
Labels
bug:minor community Community contributions
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@dhhyi @shauke