Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use correct MockComponent and MockDirective #1090

Merged
merged 1 commit into from
Mar 30, 2022
Merged

test: use correct MockComponent and MockDirective #1090

merged 1 commit into from
Mar 30, 2022

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Mar 29, 2022 •
edited by azure-boards bot
Loading

PR Type

[x] Refactoring (no functional changes, no API changes)

What is the current behavior?

Steps to reproduce:

  1. ng update ng-mocks
  2. npm run test account-overview.component.spec.ts
    MockDirective accepts directives, whereas LazyWishlistWidgetComponent is a component.

      39 |         MockComponent(OrderWidgetComponent),
      40 |         MockDirective(AuthorizationToggleDirective),
    > 41 |         MockDirective(LazyWishlistWidgetComponent),
         |                      ^
      42 |         MockDirective(ServerHtmlDirective),
      43 |         MockPipe(ServerSettingPipe, () => true),
      44 |       ],

What Is the New Behavior?

Corrected usage of MockComponent and MockDirective. This will otherwise break with the next version of ng-mocks.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#75571

@dhhyi dhhyi added refactoring Refactoring of current code community Community contributions labels Mar 29, 2022
@SGrueber SGrueber self-requested a review March 30, 2022 06:58
@SGrueber SGrueber self-assigned this Mar 30, 2022
@SGrueber SGrueber added this to the 2.2 milestone Mar 30, 2022
@SGrueber SGrueber merged commit 8cb9932 into develop Mar 30, 2022
@SGrueber SGrueber deleted the refactor/use-correct-ng-mocks branch March 30, 2022 07:00
SGrueber pushed a commit that referenced this pull request May 19, 2022
@dhhyi @SGrueber
test: use correct MockComponent and MockDirective (#1090)
b7fb4ec
SGrueber pushed a commit that referenced this pull request May 19, 2022
Merged PR 1287: Update poc Sales solution to pwa 2.2
a346ab7 
Related work items: #963, #1017, #1030, #1046, #1048, #1051, #1053, #1054, #1055, #1056, #1057, #1058, #1061, #1067, #1069, #1072, #1074, #1075, #1076, #1077, #1078, #1079, #1082, #1083, #1084, #1085, #1086, #1090, #1093, #1095, #1096, #1099, #1101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SGrueber SGrueber SGrueber approved these changes

Assignees

@SGrueber SGrueber

Labels
community Community contributions refactoring Refactoring of current code
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@dhhyi @SGrueber