Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display feedback when product is out of stock on order templates #1067

Merged
merged 4 commits into from
Mar 30, 2022

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Mar 11, 2022

PR Type

[x] Feature

What Is the Current Behavior?

Issue Number: Closes #1052

What Is the New Behavior?

Display warning and disable checkbox when product is out of stock on an order template.

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

TODO

  • The proposed info message has three pluralizations, maybe simplify:
    1 item in your order template is out of stock. This item cannot be added to the shopping cart.
    2 items in your order template are out of stock. These items cannot be added to the shopping cart.
  • Unit testing? I didn't find any, so I wrote none 😅
  • Translations for other languages
  • fix spaces for info message in phone view

Other Information

AB#75189

@dhhyi dhhyi added enhancement Enhancement to an existing feature community Community contributions labels Mar 11, 2022
@dhhyi dhhyi force-pushed the feat/order-templates-out-of-stock-feedback branch 2 times, most recently from 233f4f9 to 5775d01 Compare March 11, 2022 19:35
@dhhyi dhhyi requested a review from M-Behr March 12, 2022 07:33
@SGrueber SGrueber self-requested a review March 14, 2022 08:37
@SGrueber SGrueber self-assigned this Mar 14, 2022
@SGrueber SGrueber added this to the 2.2 milestone Mar 14, 2022
Copy link

@M-Behr M-Behr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fantastic. I found a little styling issue in mobile with the info message:

image

Other info messages look fine. So it seems to be an issue on this page, no general thing.

@dhhyi dhhyi force-pushed the feat/order-templates-out-of-stock-feedback branch from 5910de5 to 7da87f5 Compare March 22, 2022 10:18
@dhhyi dhhyi requested a review from M-Behr March 24, 2022 09:31
Copy link

@M-Behr M-Behr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👍

@SGrueber SGrueber merged commit 7c84791 into develop Mar 30, 2022
@SGrueber SGrueber deleted the feat/order-templates-out-of-stock-feedback branch March 30, 2022 09:17
SGrueber added a commit that referenced this pull request May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contributions enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order templates - Behavior of adding products to cart during out of stock products are in the list
3 participants