Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup testbed in parallel #1072

Merged
merged 10 commits into from
Mar 21, 2022
Merged

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Mar 20, 2022

PR Type

[x] Refactoring (no functional changes, no API changes)

What Is the Current Behavior?

Not everything was cleaned up properly in #1057

What Is the New Behavior?

  • cleanup-testbed runs in parallel.
  • cleanup additional tests

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Cleanups

  • src/app/core
  • projects
  • src/app/shell
  • src/app/shared
  • src/app/extensions
  • src/app/pages

Other Information

AB#75376

@dhhyi dhhyi self-assigned this Mar 20, 2022
@dhhyi dhhyi added refactoring Refactoring of current code community Community contributions labels Mar 20, 2022
@dhhyi dhhyi changed the title Refactor/cleanup testbed parallel refactor: cleanup testbed in parallel Mar 20, 2022
@dhhyi dhhyi force-pushed the refactor/cleanup-testbed-parallel branch 2 times, most recently from 098383e to 35de7e5 Compare March 20, 2022 21:57
@dhhyi dhhyi force-pushed the refactor/cleanup-testbed-parallel branch from 35de7e5 to 4fd5260 Compare March 20, 2022 22:32
@dhhyi dhhyi marked this pull request as ready for review March 21, 2022 01:01
@dhhyi dhhyi requested a review from shauke March 21, 2022 01:01
@dhhyi dhhyi removed their assignment Mar 21, 2022
@shauke shauke merged commit 32953c1 into develop Mar 21, 2022
@shauke shauke deleted the refactor/cleanup-testbed-parallel branch March 21, 2022 11:50
@shauke shauke added this to the 2.2 milestone Mar 21, 2022
SGrueber pushed a commit that referenced this pull request May 19, 2022
…changes (#1072)

* feat: parallel execution for cleanup-testbed
* test: remove DummyComponent from tests with routing
* test: cleanup testbed in src/app/core
* test: cleanup testbed in projects
* test: cleanup testbed in src/app/shell
* test: cleanup testbed in src/app/extensions
* test: cleanup testbed in src/app/pages
* test: cleanup testbed in src/app/shared
* test: remove empty testbed configurations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contributions refactoring Refactoring of current code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants