Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: lint and cleanup typings #1077

Merged
merged 1 commit into from
Mar 31, 2022
Merged

chore: lint and cleanup typings #1077

merged 1 commit into from
Mar 31, 2022

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Mar 22, 2022 •
edited
Loading

PR Type

[x] Refactoring (no functional changes, no API changes)

What Is the Current Behavior?

eslint ignore excludes typings

What Is the New Behavior?

  • typings cleanup
  • more specific eslint ignores

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#75418

@dhhyi dhhyi marked this pull request as draft March 22, 2022 13:16
@dhhyi dhhyi added enhancement Enhancement to an existing feature community Community contributions labels Mar 22, 2022
@dhhyi dhhyi force-pushed the chore/eslint-ignore-improvements branch from e870348 to 4049958 Compare March 22, 2022 14:56
@dhhyi dhhyi force-pushed the chore/eslint-ignore-improvements branch from 4049958 to b391211 Compare March 30, 2022 13:12
@dhhyi dhhyi force-pushed the chore/eslint-ignore-improvements branch from b391211 to 97a20fd Compare March 30, 2022 13:44
@dhhyi dhhyi changed the title chore: eslint ignore improvements chore: lint and cleanup typings Mar 30, 2022
@dhhyi dhhyi marked this pull request as ready for review March 30, 2022 15:32
@shauke shauke added this to the 2.2 milestone Mar 31, 2022
@shauke shauke merged commit 9e0f061 into develop Mar 31, 2022
@shauke shauke deleted the chore/eslint-ignore-improvements branch March 31, 2022 08:49
SGrueber pushed a commit that referenced this pull request May 19, 2022
@dhhyi @SGrueber
chore: lint and cleanup typings (#1077)
ebf938e
SGrueber pushed a commit that referenced this pull request May 19, 2022
Merged PR 1287: Update poc Sales solution to pwa 2.2
a346ab7 
Related work items: #963, #1017, #1030, #1046, #1048, #1051, #1053, #1054, #1055, #1056, #1057, #1058, #1061, #1067, #1069, #1072, #1074, #1075, #1076, #1077, #1078, #1079, #1082, #1083, #1084, #1085, #1086, #1090, #1093, #1095, #1096, #1099, #1101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shauke shauke shauke approved these changes

Assignees
No one assigned
Labels
community Community contributions enhancement Enhancement to an existing feature
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@dhhyi @shauke