Switch to Scala 2.13 #25190

ioannakok · 2022-07-05T15:11:39Z

Switch to Scala 2.13. This PR is big but also fixes the following syntax errors that could not get while we were on Scala 2.12:

Replaces imports of scala.collection.JavaConverters._ with scala.jdk.CollectionConverters._ because JavaConverters is deprecated.
Introduces scala-collection-plus library in order to be able to replace the deprecated mapValues method with the library's mapV.
Deletes superfluous implicits.Collections class.
Replaces deprecated zipped with lazyZip().
We become explicit about filterKeys() being a view method.
Either is now right biased.
Uses EitherValues in tests that are accessing Either values.
Adds toMap to ensure we're not returning an Iterable.
Ensures football matches are explicitly sorted.
Updates data test files.

Co-authored-by: Roberto Tyley roberto.tyley@guardian.co.uk

see Google doc of tricky errors

Previous PRs preparing for this upgrade:

Dependencies

Syntax errors

Tested

Locally
On CODE (optional)

ioannakok · 2022-07-05T16:13:55Z

common/app/implicits/Collections.scala

-
-      builder.result
-    }
+//    def distinctBy[S](hash: T => S)(implicit cbf: CanBuildFrom[C[T], T, C[T]]): C[T] = {


I didn't know how to fix this so I commented it out for now to get the next errors

This is code where Frontend devs are extending the functionality of Scala's collection classes. Unfortunately there was a big improving refactor in Scala colllections going from Scala 2.12 to 2.13, and consequently the code would no longer be extended in the same way. See the migration guide here:

https://docs.scala-lang.org/overviews/core/collections-migration-213.html

In particular, the implicit cbf: CanBuildFrom stuff went away:

Transformation methods no longer have an implicit CanBuildFrom parameter. This makes the library easier to understand (in source code, Scaladoc, and IDE code completion). It also makes compiling user code more efficient.

Extending Scala collections is now done in a different way - see the guide here : https://docs.scala-lang.org/overviews/core/custom-collection-operations.html - eg the part where a new .sumBy() method is added to existing collections. Another example of this is in https://github.com/rtyley/scala-collection-plus/blob/master/collection-plus/src/main/scala/com/madgag/scala/collection/decorators/package.scala !

What we want to do here, I'm not sure - it would depend on how often and where these methods are called, if we still want to implement them - maybe there are even better methods of providing this functionality?

maybe there are even better methods of providing this functionality?

LOL, yes there is! Turns out there is a brand new method in Scala 2.13 that is called the exact same name - distinctBy() - and is called in exactly the same way. This means that all of Seq2Distinct can be deleted with Scala 2.13 ✨

In fact, it looks like we can delete this entire file - see #25226

In the course of upgrading the Frontend codebase to Scala 2.13 (see #25190) we came across the `implicits.Collections` class, and had trouble upgrading it: #25190 (comment) It turns out that we will be able to _delete_ this class with the Scala 2.13 upgrade, rather than have to update it, which is nice! To reduce the size of the Scala 2.13 upgrade PR, we're removing superfluous use of the `implicits.Collections` class in this pre-upgrade PR. `implicits.Collections` is currently used to add two additional methods to standard Scala collections: * `distinctBy()` - introduced November 2012 with #263. Perhaps surprisingly, Scala 2.13 has a new built-in method that is called the same thing and is called the same way! So the Frontend implementation can be deleted when the Scala 2.13 upgrade occurs. https://www.scala-lang.org/api/2.13.x/scala/collection/Seq.html#distinctBy[B](f:A=%3EB):C * `safeDropWhile()` - introduced January 2015 with #7706 to handle a problem with the Scala 2.11 compiler: scala/bug#7529 The issue is no longer present in Scala 2.12, so the method could have been removed when the upgrade to Scala 2.12 was performed in November 2017 with #18218 This pre-upgrade PR deletes the unnecessary `safeDropWhile()` method, and removes several unnecessary references to `implicits.Collections`.

In the course of upgrading the Frontend codebase to Scala 2.13 we came across the `implicits.Collections` class, and had trouble updating it for Scala 2.13: #25190 (comment) It turns out that we can _delete_ this class with the Scala 2.13 upgrade, rather than have to update it, which is nice! To reduce the size of the Scala 2.13 upgrade PR, we first removed every use of `implicits.Collections` that we could while still under Scala 2.12: #25226 This commit gets rid of `implicits.Collections` altogether. At this point, all `implicits.Collections` has in it is the code to add a `distinctBy()` method onto standard Scala collections - this was introduced November 2012 with #263, but Scala 2.13 has a new built-in method that works the exact same way! So we can delete the Frontend implementation. https://www.scala-lang.org/api/2.13.x/scala/collection/Seq.html#distinctBy%5BB%5D(f:A=%3EB):C

In the course of upgrading the Frontend codebase to Scala 2.13 (see #25190) we came across the `implicits.Collections` class, and had trouble upgrading it: #25190 (comment) It turns out that we will be able to _delete_ this class with the Scala 2.13 upgrade, rather than have to update it, which is nice! To reduce the size of the Scala 2.13 upgrade PR, we're removing superfluous use of the `implicits.Collections` class in this pre-upgrade PR. `implicits.Collections` is currently used to add two additional methods to standard Scala collections: * `distinctBy()` - introduced November 2012 with #263. Perhaps surprisingly, Scala 2.13 has a new built-in method that is called the same thing and is called the same way! So the Frontend implementation can be deleted when the Scala 2.13 upgrade occurs. https://www.scala-lang.org/api/2.13.x/scala/collection/Seq.html#distinctBy[B](f:A=%3EB):C * `safeDropWhile()` - introduced January 2015 with #7706 to handle a problem with the Scala 2.11 compiler: scala/bug#7529 The issue is no longer present in Scala 2.12, so the method could have been removed when the upgrade to Scala 2.12 was performed in November 2017 with #18218 This pre-upgrade PR deletes the unnecessary `safeDropWhile()` method, and removes several unnecessary references to `implicits.Collections`.

In the course of upgrading the Frontend codebase to Scala 2.13 we came across the `implicits.Collections` class, and had trouble updating it for Scala 2.13: #25190 (comment) It turns out that we can _delete_ this class with the Scala 2.13 upgrade, rather than have to update it, which is nice! To reduce the size of the Scala 2.13 upgrade PR, we first removed every use of `implicits.Collections` that we could while still under Scala 2.12: #25226 This commit gets rid of `implicits.Collections` altogether. At this point, all `implicits.Collections` has in it is the code to add a `distinctBy()` method onto standard Scala collections - this was introduced November 2012 with #263, but Scala 2.13 has a new built-in method that works the exact same way! So we can delete the Frontend implementation. https://www.scala-lang.org/api/2.13.x/scala/collection/Seq.html#distinctBy%5BB%5D(f:A=%3EB):C

`LiveBlogCurrentPage.findPageWithBlock()` is responsible for making sure that when a user clicks on a live-blog permalink to a **block**, eg: https://www.theguardian.com/politics/live/2022/aug/01/tory-leadership-race-rishi-sunak-lizz-truss-vote-keir-starmer-uk-politics-live?page=with:block-62e7e89d8f08730a1f7f5579#block-62e7e89d8f08730a1f7f5579 ...the user is taken to the correct 'page' of the live blog - page 3 of 5 in the example above, for instance. The code was was first introduced in January 2016 with #11700, subsequently updated with #13566, etc. The existing code compiles without warnings under Scala 2.12, but the Scala 2.13 compiler gives a warning that not _all_ conceivable cases in the pattern-match are handled: ``` frontend/common/app/model/LiveBlogCurrentPage.scala:190:12: match may not be exhaustive. [warn] It would fail on the following inputs: List(_), Nil [warn] .map { [warn] ^ ``` In this particular case, the warning's unnecessary - the preceding `.sliding(3)`: https://github.com/guardian/frontend/blob/f90c8a58e6f0941c96392d14fe27e61a4dbaf25b/common/app/model/LiveBlogCurrentPage.scala#L188 ...means that the List supplied to the case match expression will _always_ have 3 elements, and that's precisely the case that's handled - but there's no way for the compiler to know that - so we as devs need to do _something_ to make the warning go away! See also: * The Scala 2.13 upgrade PR: #25190

@unchecked

`LiveBlogCurrentPage.findPageWithBlock()` is responsible for making sure that when a user clicks on a live-blog permalink to a **block**, eg: https://www.theguardian.com/politics/live/2022/aug/01/tory-leadership-race-rishi-sunak-lizz-truss-vote-keir-starmer-uk-politics-live?page=with:block-62e7e89d8f08730a1f7f5579#block-62e7e89d8f08730a1f7f5579 ...the user is taken to the correct 'page' of the live blog - page 3 of 5 in the example above, for instance. The code was was first introduced in January 2016 with #11700, subsequently updated with #13566, etc. The existing code compiles without warnings under Scala 2.12, but the Scala 2.13 compiler gives a warning that not _all_ conceivable cases in the pattern-match are handled: ``` frontend/common/app/model/LiveBlogCurrentPage.scala:190:12: match may not be exhaustive. [warn] It would fail on the following inputs: List(_), Nil [warn] .map { [warn] ^ ``` In this particular case, the warning's unnecessary - the preceding `.sliding(3)`: https://github.com/guardian/frontend/blob/f90c8a58e6f0941c96392d14fe27e61a4dbaf25b/common/app/model/LiveBlogCurrentPage.scala#L188 ...means that the `List` supplied to the case match expression will _always_ have 3 elements, and that's precisely the case that is handled - but there's no way for the compiler to know that - so we as devs need to do _something_ to make the warning go away! Some options: * Use the @unchecked annotation (see https://www.scala-lang.org/api/2.12.7/scala/unchecked.html) This is an option of last resort - turning off compiler checks leaves us exposed to runtime errors and is generally a bad idea! * Use `collect()` rather than `map()` - this accepts a partial function, rather than a total one, so the compiler error will go away. https://www.scala-lang.org/api/2.12.7/scala/collection/immutable/Seq.html#collectFirst[B](pf:PartialFunction[A,B]):Option[B] * Refactor so that the code no longer needs to assume that a `List` type (which can have any length) has length `3`. In the end I decided to go with the refactor, because there were a few things about the existing code that could be tweaked: * Unnecessary work: The method was creating a `LiveBlogCurrentPage` for _every_ page in the liveblog, even though it only ever needed one (the single page that the block actually exists on!), and would eventually throw away the rest. * The logic around padding the front & end of the `pages` List with two `None` entries, to allow extracting the `newer` & `older` pages, totally worked but added an extra step to the code (and therefore a bit of complexity for humans to understand: "what are endedPages?") and could be replaced by just incrementing/decrementing the page index for the one `LiveBlogCurrentPage` we're now creating. * Various variables could be inlined to the point of creation on the `LiveBlogCurrentPage` case class. By using named parameters in constructing the case class, no clarity is lost, and the code is more concise. See also: * The Scala 2.13 upgrade PR: #25190

In the course of upgrading the Frontend codebase to Scala 2.13 we came across the `implicits.Collections` class, and had trouble updating it for Scala 2.13: #25190 (comment) It turns out that we can _delete_ this class with the Scala 2.13 upgrade, rather than have to update it, which is nice! To reduce the size of the Scala 2.13 upgrade PR, we first removed every use of `implicits.Collections` that we could while still under Scala 2.12: #25226 This commit gets rid of `implicits.Collections` altogether. At this point, all `implicits.Collections` has in it is the code to add a `distinctBy()` method onto standard Scala collections - this was introduced November 2012 with #263, but Scala 2.13 has a new built-in method that works the exact same way! So we can delete the Frontend implementation. https://www.scala-lang.org/api/2.13.x/scala/collection/Seq.html#distinctBy%5BB%5D(f:A=%3EB):C

ioannakok · 2022-08-26T12:13:40Z

common/test/common/ModelOrResultTest.scala

@@ -15,7 +16,7 @@ import scala.concurrent.Future

 private object TestModel

-class ModelOrResultTest extends AnyFlatSpec with Matchers with WithTestExecutionContext {
+class ModelOrResultTest extends AnyFlatSpec with Matchers with WithTestExecutionContext with EitherValues {


"ScalaTest's EitherValues trait provides an implicit conversion that adds left.value and right.value methods to Either, which will return the selected value of the Either if defined": https://www.scalatest.org/user_guide/using_EitherValues

ioannakok · 2022-08-26T12:15:20Z

sport/app/football/model/CompetitionStages.scala

@@ -20,7 +20,7 @@ class CompetitionStage(competitions: Seq[Competition]) {
      competition: Competition,
      orderings: Map[String, List[ZonedDateTime]] = Map.empty,
  ): List[CompetitionStageLike] = {
-    val stagesWithMatches = competition.matches.toList.groupBy(_.stage).toList
+    val stagesWithMatches = competition.matches.groupBy(_.stage).toList.sortBy(_._1.stageNumber.toIntOption)


The code previously relied on groupBy producing a Map that had the keys in the 'natural' order of stage 1, stage 2 - but didn't have any sorting to enforce that. Maps are unordered collections, and so there was never a guarantee that Scala 2.13 will put Map keys in the same order as Scala 2.12.

mxdvl

Massive effort! Well done on both of you.

mxdvl · 2022-08-26T14:17:09Z

project/Dependencies.scala

@@ -52,6 +52,7 @@ object Dependencies {
  val rome = "rome" % "rome" % romeVersion
  val romeModules = "org.rometools" % "rome-modules" % romeVersion
  val scalaCheck = "org.scalacheck" %% "scalacheck" % "1.16.0" % Test
+  val scalaCollectionPlus = "com.madgag" %% "scala-collection-plus" % "0.11"


Who’s this madgag fellow?

I don't know but I have often wondered myself 😆

I purchased madgag.com back in 2003 (as the domain for a comedy listings site I was trying to create as a side-project - I didn't realise there was already the Chortle website doing the same thing!). As the website was for getting to comedy gigs in obscure places, I wanted it to be accessible by mobile phone, which at the time was at the very edge of what phones could do - the iPhone wouldn't launch for another 4 years. Phones had screens, but not touchscreens, just numeric keypads, like this:

At the time the fastest way of typing text - eg a url - into a phone was using T9 (predictive text), so I wanted my domain name to be not only comedy-related, but easy to type in - that meant finding a name that only used the first letters of the numeric keypad (A, D, G, J, M, P, T, W). I came up with madgag, which is very easy to type using a T9 keypad...!

Although I had a fun time writing the code for madgag.com, it was never fully developed, and I turned it off a few years later. However, in writing the site, I happened to learn a bunch of stuff about databases and object-relational-mapping, which - guess what - came up when I had my phone interview at the Guardian! So the interview went well, and helped me get the job here!

mxdvl · 2022-08-26T14:17:30Z

project/ProjectSettings.scala

@@ -32,7 +32,7 @@ object ProjectSettings {
    Compile / packageDoc / publishArtifact := false,
    Compile / doc / sources := Seq.empty,
    Compile / doc := target.map(_ / "none").value,
-    scalaVersion := "2.12.13",
+    scalaVersion := "2.13.8",


Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

…collection.JavaConverters._ `scala.collection.JavaConverters` is deprecated. Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

…apValues` Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

In the course of upgrading the Frontend codebase to Scala 2.13 we came across the `implicits.Collections` class, and had trouble updating it for Scala 2.13: #25190 (comment) It turns out that we can _delete_ this class with the Scala 2.13 upgrade, rather than have to update it, which is nice! To reduce the size of the Scala 2.13 upgrade PR, we first removed every use of `implicits.Collections` that we could while still under Scala 2.12: #25226 This commit gets rid of `implicits.Collections` altogether. At this point, all `implicits.Collections` has in it is the code to add a `distinctBy()` method onto standard Scala collections - this was introduced November 2012 with #263, but Scala 2.13 has a new built-in method that works the exact same way! So we can delete the Frontend implementation. Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

> TupleNZipped has been replaced with LazyZipN: > (xs, ys).zipped -> xs.lazyZip(ys) https://docs.scala-lang.org/overviews/core/collections-migration-213.html#breaking-changes-with-old-syntax-still-supported scala/collection-strawman#223 Although .zipped is only deprecated, we have deprecation warnings set as fatal errors in the frontend project. Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

Great explanation in the Ophan repo Scala 2.13 upgrade about why this change is needed: guardian/ophan@e9ff516 Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

Method right in class Either is deprecated (since 2.13.0): Either is now right-biased and we can use methods directly on it Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

We are trying to call `toIntOption`, a method of `StringOps` on a `String` so we're getting the error: ``` value toIntOption is not a member of String ``` Normally, we would expect implicit conversions to have worked and change String to StringOps but in this case they don't and we're getting: ``` [error] Note that implicit conversions are not applicable because they are ambiguous: [error] both method augmentString in object Predef of type (x: String): scala.collection.StringOps [error] and method String2ToOptions in trait Strings of type (s: String): common.package.String2ToOptions [error] are possible conversion functions from x$4.type to ?{def toIntOption: ?} ``` So we have to explictly call `augmentString()` to trun `String` to `StringOps` and have access to `toIntOption` method. Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

Otherwise we're getting this error: ``` [error] /Users/Ioanna_Kokkini/Projects/frontend/common/app/views/support/JavaScriptPage.scala:103:7: type mismatch [error] found : scala.collection.immutable.Iterable[(String, play.api.libs.json.JsValue)] [error] required: Map[String,play.api.libs.json.JsValue] [error] ) ++ commercialBundleUrl [error] ^ ``` Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

The code previously relied on `groupBy` producing a Map that had the keys in the 'natural' order of stage 1, stage 2 - but didn't have any sorting to enforce that. Maps are unordered collections, and so there was never a guarantee that Scala 2.13 put Map keys in the same order as Scala 2.12. Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

prout-bot · 2022-08-31T09:09:11Z

Seen on PROD (merged by @ioannakok 15 minutes and 31 seconds ago)

Check your changes on www.theguardian.com ✔️
Keep an eye on the deploy dashboard 📉

rtyley · 2022-09-06T13:06:42Z

Massive congratulations on getting this out @ioannakok !

ioannakok commented Jul 5, 2022

View reviewed changes

ioannakok force-pushed the roberto-ioanna/scala-2.13-new branch from c9ae1e3 to e6e3621 Compare July 6, 2022 19:48

ioannakok changed the title ~~Roberto ioanna/scala 2.13 new~~ Switch to Scala 2.13 Jul 8, 2022

rtyley force-pushed the roberto-ioanna/scala-2.13-new branch 2 times, most recently from 8b5abeb to 7bc1127 Compare July 12, 2022 11:36

rtyley mentioned this pull request Jul 12, 2022

Remove superfluous use of implicits.Collections #25226

Merged

rtyley force-pushed the roberto-ioanna/scala-2.13-new branch from 7bc1127 to 74aa1bc Compare July 12, 2022 16:38

rtyley force-pushed the roberto-ioanna/scala-2.13-new branch from 74aa1bc to 9e05a7f Compare July 13, 2022 07:58

rtyley force-pushed the roberto-ioanna/scala-2.13-new branch from 9e05a7f to cb96cd0 Compare July 13, 2022 07:59

rtyley mentioned this pull request Jul 27, 2022

Scala 2.13: Fix ambiguous overloaded JsonComponent method #25288

Merged

rtyley force-pushed the roberto-ioanna/scala-2.13-new branch from cb96cd0 to a92eaf0 Compare July 27, 2022 11:06

This was referenced Aug 2, 2022

Bye bye facia tool #10585

Merged

Multiple refactorings in common/app/layout #22392

Merged

ioannakok force-pushed the roberto-ioanna/scala-2.13-new branch from a92eaf0 to 4bddfbb Compare August 2, 2022 15:30

rtyley mentioned this pull request Aug 3, 2022

Scala 2.13: Refactor LiveBlogCurrentPage.findPageWithBlock() #25338

Merged

ioannakok force-pushed the roberto-ioanna/scala-2.13-new branch from 4bddfbb to 3b418b3 Compare August 5, 2022 15:48

ioannakok force-pushed the roberto-ioanna/scala-2.13-new branch from 7f4e3a4 to 4cb721e Compare August 9, 2022 16:58

rtyley mentioned this pull request Aug 9, 2022

Remove storyquestions atom #21897

Merged

ioannakok mentioned this pull request Aug 11, 2022

Scala-2.13: Use Symbol instead of single-quote syntax #25367

Merged

ioannakok commented Aug 26, 2022

View reviewed changes

ioannakok marked this pull request as ready for review August 26, 2022 12:15

ioannakok requested review from a team as code owners August 26, 2022 12:15

mxdvl approved these changes Aug 26, 2022

View reviewed changes

mxdvl reviewed Aug 26, 2022

View reviewed changes

ioannakok and others added 12 commits August 31, 2022 09:33

Switch scalaVersion to 2.13

aedab11

Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

Scala 2.13: Import scala.jdk.CollectionConverters._ instead of scala.…

d3c819c

…collection.JavaConverters._ `scala.collection.JavaConverters` is deprecated. Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

Scala 2.13: Use scala-collection-plus mapV to replace deprecated `m…

f1e1148

…apValues` Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

Scala 2.13: .filterKeys() is now explicit about being a 'view' method

7a30a5c

Great explanation in the Ophan repo Scala 2.13 upgrade about why this change is needed: guardian/ophan@e9ff516 Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

Scala 2.13: Either is now Right-biased

98026c0

Method right in class Either is deprecated (since 2.13.0): Either is now right-biased and we can use methods directly on it Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

Scala 2.13: Use EitherValues in tests that are accessing Either values

e2d151b

Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

Scala 2.13: Update data test files

53b68a9

Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

ioannakok force-pushed the roberto-ioanna/scala-2.13-new branch from e3b3ed2 to 53b68a9 Compare August 31, 2022 08:36

ioannakok merged commit 0f861d6 into main Aug 31, 2022

ioannakok deleted the roberto-ioanna/scala-2.13-new branch August 31, 2022 08:53

prout-bot added Pending-on-PROD Seen-on-PROD and removed Pending-on-PROD labels Aug 31, 2022

mxdvl mentioned this pull request Aug 31, 2022

Scala 2.12 -> 2.13 #24817

Closed

rtyley added the Scala 2.13 See https://github.com/guardian/maintaining-scala-projects/issues/2 label Feb 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch to Scala 2.13 #25190

Switch to Scala 2.13 #25190

ioannakok commented Jul 5, 2022 •

edited

Loading

ioannakok Jul 5, 2022

rtyley Jul 12, 2022

rtyley Jul 12, 2022 •

edited

Loading

ioannakok Aug 26, 2022

ioannakok Aug 26, 2022

mxdvl left a comment

mxdvl Aug 26, 2022

ioannakok Aug 31, 2022

rtyley Sep 6, 2022

mxdvl Aug 26, 2022

prout-bot commented Aug 31, 2022

rtyley commented Sep 6, 2022

Switch to Scala 2.13 #25190

Switch to Scala 2.13 #25190

Conversation

ioannakok commented Jul 5, 2022 • edited Loading

Previous PRs preparing for this upgrade:

Dependencies

Syntax errors

Tested

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rtyley Jul 12, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mxdvl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prout-bot commented Aug 31, 2022

rtyley commented Sep 6, 2022

ioannakok commented Jul 5, 2022 •

edited

Loading

rtyley Jul 12, 2022 •

edited

Loading