Scala 2.12 Upgrade #18218
Merged
Scala 2.12 Upgrade #18218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuarpT
commented
Nov 10, 2017
project/Dependencies.scala
Outdated
| @@ -3,15 +3,16 @@ package com.gu | |||
| import sbt._ | |||
|
|
|||
| object Dependencies { | |||
| val identityLibVersion = "3.83" | |||
| val identityLibVersion = "3.85-SNAPSHOT" | |||
There was a problem hiding this comment.
TODO: release identity lib and update this
QuarpT
commented
Nov 10, 2017
| @@ -1,42 +1,43 @@ | |||
| package cricket.feed | |||
There was a problem hiding this comment.
I've rewritten the throttled task since Throttled actor is deprecated. I will cherry-pick this into 2.11 and release separately
|
PRbuilds results: Screenshots 💚 Exceptions 💚 A11y validation Apache Benchmark Load Testing 💚 Microdata Validation --automated message |
TBonnin
approved these changes
Nov 15, 2017
|
Great! Thanks so much for doing this @QuarpT ! |
|
Seen on PROD (merged by @QuarpT 19 minutes and 32 seconds ago)
|
rtyley
added a commit
that referenced
this pull request
Jul 12, 2022
In the course of upgrading the Frontend codebase to Scala 2.13 (see #25190) we came across the `implicits.Collections` class, and had trouble upgrading it: #25190 (comment) It turns out that we will be able to _delete_ this class with the Scala 2.13 upgrade, rather than have to update it, which is nice! To reduce the size of the Scala 2.13 upgrade PR, we're removing superfluous use of the `implicits.Collections` class in this pre-upgrade PR. `implicits.Collections` is currently used to add two additional methods to standard Scala collections: * `distinctBy()` - introduced November 2012 with #263. Perhaps surprisingly, Scala 2.13 has a new built-in method that is called the same thing and is called the same way! So the Frontend implementation can be deleted when the Scala 2.13 upgrade occurs. https://www.scala-lang.org/api/2.13.x/scala/collection/Seq.html#distinctBy[B](f:A=%3EB):C * `safeDropWhile()` - introduced January 2015 with #7706 to handle a problem with the Scala 2.11 compiler: scala/bug#7529 The issue is no longer present in Scala 2.12, so the method could have been removed when the upgrade to Scala 2.12 was performed in November 2017 with #18218 This pre-upgrade PR deletes the unnecessary `safeDropWhile()` method, and removes several unnecessary references to `implicits.Collections`.
rtyley
added a commit
that referenced
this pull request
Jul 13, 2022
In the course of upgrading the Frontend codebase to Scala 2.13 (see #25190) we came across the `implicits.Collections` class, and had trouble upgrading it: #25190 (comment) It turns out that we will be able to _delete_ this class with the Scala 2.13 upgrade, rather than have to update it, which is nice! To reduce the size of the Scala 2.13 upgrade PR, we're removing superfluous use of the `implicits.Collections` class in this pre-upgrade PR. `implicits.Collections` is currently used to add two additional methods to standard Scala collections: * `distinctBy()` - introduced November 2012 with #263. Perhaps surprisingly, Scala 2.13 has a new built-in method that is called the same thing and is called the same way! So the Frontend implementation can be deleted when the Scala 2.13 upgrade occurs. https://www.scala-lang.org/api/2.13.x/scala/collection/Seq.html#distinctBy[B](f:A=%3EB):C * `safeDropWhile()` - introduced January 2015 with #7706 to handle a problem with the Scala 2.11 compiler: scala/bug#7529 The issue is no longer present in Scala 2.12, so the method could have been removed when the upgrade to Scala 2.12 was performed in November 2017 with #18218 This pre-upgrade PR deletes the unnecessary `safeDropWhile()` method, and removes several unnecessary references to `implicits.Collections`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: still need to update identity dependencies - currently relies on local snapshots. Can still review in the meantime.
What does this change?
Scala version, 2.11 to 2.12
What is the value of this and can you measure success?
Continued support for libraries
Screenshots
Tested in CODE?
We will need to smoke test this thoroughly