-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala 2.11.4 #7706
Scala 2.11.4 #7706
Conversation
@@ -29,7 +30,7 @@ trait DataAgent[K, V] extends ExecutionContexts with Logging { | |||
oldCache | |||
} | |||
case Failure(e) => | |||
log.error(e.getStackTraceString) | |||
log.error(ExceptionUtils.getStackTrace(e)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Nice work, well overdue 👍 |
@@ -46,11 +45,12 @@ object Dependencies { | |||
val scalaCheck = "org.scalacheck" %% "scalacheck" % "1.11.5" % "test" | |||
val scalajTime = "org.scalaj" % "scalaj-time_2.10.2" % "0.7" | |||
val scalaTest = "org.scalatest" %% "scalatest" % "2.2.1" % Test | |||
val scalaz = "org.scalaz" %% "scalaz-core" % "7.0.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you quietly delete this pull request then I think we can be convinced to pretend it never happened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it wasn't me! whoever started using scalaz without adding a direct dependency, tut tut.
In the course of upgrading the Frontend codebase to Scala 2.13 (see #25190) we came across the `implicits.Collections` class, and had trouble upgrading it: #25190 (comment) It turns out that we will be able to _delete_ this class with the Scala 2.13 upgrade, rather than have to update it, which is nice! To reduce the size of the Scala 2.13 upgrade PR, we're removing superfluous use of the `implicits.Collections` class in this pre-upgrade PR. `implicits.Collections` is currently used to add two additional methods to standard Scala collections: * `distinctBy()` - introduced November 2012 with #263. Perhaps surprisingly, Scala 2.13 has a new built-in method that is called the same thing and is called the same way! So the Frontend implementation can be deleted when the Scala 2.13 upgrade occurs. https://www.scala-lang.org/api/2.13.x/scala/collection/Seq.html#distinctBy[B](f:A=%3EB):C * `safeDropWhile()` - introduced January 2015 with #7706 to handle a problem with the Scala 2.11 compiler: scala/bug#7529 The issue is no longer present in Scala 2.12, so the method could have been removed when the upgrade to Scala 2.12 was performed in November 2017 with #18218 This pre-upgrade PR deletes the unnecessary `safeDropWhile()` method, and removes several unnecessary references to `implicits.Collections`.
In the course of upgrading the Frontend codebase to Scala 2.13 (see #25190) we came across the `implicits.Collections` class, and had trouble upgrading it: #25190 (comment) It turns out that we will be able to _delete_ this class with the Scala 2.13 upgrade, rather than have to update it, which is nice! To reduce the size of the Scala 2.13 upgrade PR, we're removing superfluous use of the `implicits.Collections` class in this pre-upgrade PR. `implicits.Collections` is currently used to add two additional methods to standard Scala collections: * `distinctBy()` - introduced November 2012 with #263. Perhaps surprisingly, Scala 2.13 has a new built-in method that is called the same thing and is called the same way! So the Frontend implementation can be deleted when the Scala 2.13 upgrade occurs. https://www.scala-lang.org/api/2.13.x/scala/collection/Seq.html#distinctBy[B](f:A=%3EB):C * `safeDropWhile()` - introduced January 2015 with #7706 to handle a problem with the Scala 2.11 compiler: scala/bug#7529 The issue is no longer present in Scala 2.12, so the method could have been removed when the upgrade to Scala 2.12 was performed in November 2017 with #18218 This pre-upgrade PR deletes the unnecessary `safeDropWhile()` method, and removes several unnecessary references to `implicits.Collections`.
Upgrades us and our libraries to 2.11. It allegedly had optimizer and incremental build improvements, so we may see better execution and develop-iteration performance.
Also got rid of the jboss dependency and some resolvers, trying to keep the resolver list very small to improve sbt dependency speed.