Remove storyquestions atom #21897
Merged
Remove storyquestions atom #21897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 9, 2019 15:04
regiskuckaertz
commented
Oct 9, 2019
added 6 commits
October 9, 2019 15:15
|
PRbuilds results: Screenshots 💚 A11y validation 💚 Microdata Validation Apache Benchmark Load Testing LightHouse Reporting --automated message |
added 2 commits
October 10, 2019 09:04
|
All looking good now 🎉 |
|
Tangentially, we might need to update @AWare's Typescript / Thrift / CAPI unification experiment? |
|
Yes, I would advise doing so. Can I get a +1? 🙏 |
added 3 commits
October 18, 2019 11:39
…nd into rk-remove-storyquestions
shtukas
approved these changes
Nov 11, 2019
|
Overdue on PROD (merged by @regiskuckaertz 30 minutes and 6 seconds ago) What's gone wrong? |
|
Seen on PROD (merged by @regiskuckaertz 3 hours, 25 minutes and 25 seconds ago)
|
rtyley
reviewed
Aug 9, 2022
| @@ -79,8 +79,6 @@ class AtomPageController(contentApiClient: ContentApiClient, wsClient: WSClient, | |||
| lookup(s"atom/$atomType/$id") map { | |||
| case Left(model: MediaAtom) => | |||
| renderAtom(MediaAtomPage(model, withJavaScript = isJsEnabled, withVerticalScrollbar = hasVerticalScrollbar)) | |||
| case Left(model: StoryQuestionsAtom) => | |||
| renderAtom(StoryQuestionsAtomPage(model, withJavaScript = isJsEnabled, withVerticalScrollbar = hasVerticalScrollbar, inApp = inApp)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up after ourselves. The storyquestions atom has been decommissioned.