Scala 2.13: Replace deprecated procedure syntax with explicit ': Unit =' #25188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannakok
force-pushed
the
roberto-ioanna/scala-2.13-replace-deprecated-procedure-syntax
branch
from
7791d8d
to
affbdf3
Compare
We're trying to fix as many syntax errors as possible while we're still in Scala 2.12.
For this PR, we added: `addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % "0.10.1")` in
`plugins.sbt` and ran `scalafixAll ProcedureSyntax` in the `sbt` shell.
rtyley
force-pushed
the
roberto-ioanna/scala-2.13-replace-deprecated-procedure-syntax
branch
from
affbdf3
to
d0c9a74
Compare
jamesgorrie
reviewed
Jul 6, 2022
There was a problem hiding this comment.
Nice!
Been digging to find out why Unit is called Unit.
The definition in Scala is:
There is only one value of type Unit, ()
Which then led me to the Maths Wikipedia page... which was hard to read. Thought the rust description was pretty good.
Thought it relatively interesting if you're into that.
jamesgorrie
approved these changes
Jul 6, 2022
|
@jamesgorrie This is great! Thank you! |
ioannakok
deleted the
roberto-ioanna/scala-2.13-replace-deprecated-procedure-syntax
branch
|
Overdue on PROD (merged by @ioannakok 30 minutes and 7 seconds ago) What's gone wrong? |
prout-bot
added
Overdue-on-PROD
Seen-on-PROD
and removed
Pending-on-PROD
Overdue-on-PROD
labels
|
Seen on PROD (merged by @ioannakok 16 hours, 38 minutes and 54 seconds ago)
|
rtyley
added
the
Scala 2.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
We're trying to fix as many syntax errors as possible while we're still in Scala 2.12. For this PR, we added:
addSbtPlugin("ch.epfl.scala" % "sbt-scalafix" % "0.10.1")inplugins.sbtand ranscalafixAll ProcedureSyntaxin thesbtshell.