Upgrade targeting-client

[ioannakok]

What does this change?

In advance of updating the Scala version we want to update as many dependencies as possible to be compatible with both 2.12 and 2.13.

This change bumps targeting-client to the latest version which is compatible with both 2.12 and 2.13.

As part of this PR aws-java-sdk-kinesis and aws-java-sdk-ec2 had also to change from 1.11.26 to 1.11.240.

Does this change need to be reproduced in dotcom-rendering ?

• No
• Yes (please indicate your plans for DCR Implementation)

Screenshots

What is the value of this and can you measure success?

Checklist

Does this affect other platforms?

• AMP
• Apps
• Other (please specify)

Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?

• No
• Yes (please give details)

Does this change break ad-free?

• No
• It did, but tests caught it and I fixed it
• It did, but there was no test coverage so I added that then fixed it

Does this change update the version of CAPI we're using?

• No, all the existing database files are just fine
• Yes, and I have re-run all the tests locally and checked in all the updated data/database/xyz files

Accessibility test checklist

• Tested with screen reader
• Navigable with keyboard
• Colour contrast passed

Tested

• Locally
• On CODE (optional)

[DavidLawes]

NB: I think we'll also need to explicitly define the dependency for ec2 now as well. It's required here https://github.com/guardian/frontend/blob/main/admin/app/controllers/admin/TroubleshooterController.scala#L3, so we need to add val awsEc2 = "com.amazonaws" % "aws-java-sdk-ec2" % awsVersion to Dependencies.scala

[DavidLawes]

We were seeing a deprecation warning when directly instantiating the AmazonKinesisAsyncClient class. The class was being instantiated inside KinesisAdapter's create method.

• The create method overrides the sdk kinesis appender create method
• Kinesis appender create method only accepts type AmazonKinesisAsyncClient
• We override the create method so we can define custom retry policies
• We instantiate SafeBlockingKinesisAppender and then create the client in LogbackConfig

The docs suggest alternative approaches to creating service clients, specifically using a client builder. However, the resulting type of the client builder is a different type to what we need (i.e. we get AmazonKinesisAsync as opposed to AmazonKinesisAsyncClient.

From the sdk we can see that, after creating and updating the client builder, we can call the build() method to give us a new client:
protected AmazonKinesisAsync build(AwsAsyncClientParams params) { return new AmazonKinesisAsyncClient(params); }
But I couldn't understand why the type returned did not match what I thought we'd get.

[DavidLawes]

We were seeing a failing build in team city, eg https://teamcity.gutools.co.uk/viewLog.html?buildId=756934&buildTypeId=dotcom_master&tab=buildLog, due to an error during test compilation.

The error was a result of incompatible versions of scalactic. A version of scalactic was being defined in targeting-client, however that dependency did not need to be defined (it wasn't being directly used anywhere in the project).

Scalactic was removed from targeting-client and a new version of the library was published (1.1.2 - note that the deploy of 1.1.1 failed because I didn't have a valid setup, so we moved straight to publishing 1.1.2 in case there was a conflict from the partly-failed publishing of 1.1.1).

Hopefully now we have a working build - we may still want to look at removing the deprecated function.

[rtyley]

Hi @DavidLawes ! I notice that the build didn't quite pass, but if you rebase on top of main to get #24845, then this error will go away:

[15:20:23][Step 7/9] [info] - should be deleted once expired *** FAILED ***
[15:20:23][Step 7/9] [info]   true was not equal to false (switch: 'puzzles-banner') (SwitchesTest.scala:76)

[ioannakok]

This PR changes aws-java-sdk-kinesis from 1.11.26 to 1.11.240. In this version AmazonKinesisAsyncClient is deprecated. A separate ticket has been created to refactor KinesisAdapter.scala and get rid of the deprecated class and the @nowarn annotation: #24846

[OllysCoding]

+1 Looks good to me!

[prout-bot]

Seen on PROD (merged by @ioannakok 14 minutes and 52 seconds ago)

• Check your changes on www.theguardian.com ✔️
• Keep an eye on the deploy dashboard 📉