Skip to content

Commit

Permalink
stop scalactic being added as an unnecessary runtime dependency
Browse files Browse the repository at this point in the history
guardian/frontend#24833
Scalactic version conflicts were causing compilation failures when compiling tests in frontend

```
java.lang.NoSuchMethodError: 'void org.scalactic.BooleanMacro.<init>(scala.reflect.macros.whitebox.Context, java.lang.String)'
```
  • Loading branch information
DavidLawes committed Apr 1, 2022
1 parent c1d82d8 commit 887390c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ scalacOptions ++= Seq("-feature", "-deprecation")

libraryDependencies ++= Seq(
commonsIo,
scalatic,
scalaTest,
http,
playJson
Expand Down
3 changes: 1 addition & 2 deletions project/dependencies.scala
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ import sbt._

object Dependencies {
val commonsIo = "org.apache.commons" % "commons-io" % "1.3.2"
val scalatic = "org.scalactic" %% "scalactic" % "3.1.1"
val scalaTest = "org.scalatest" %% "scalatest" % "3.1.1" % "test"
val scalaTest = "org.scalatest" %% "scalatest" % "3.1.1" % Test
val http = "org.apache.httpcomponents" % "httpclient" % "4.5.12"

val playJson = "com.typesafe.play" %% "play-json" % "2.8.1"
Expand Down

0 comments on commit 887390c

Please sign in to comment.