Rename ParseResult to ParseBlockResult to avoid shadowing a nested class of a parent class

[ioannakok]

In Scala 2.13, we see this compilation error: "shadowing a nested class of a parent is deprecated but trait ParseResult shadows class ParseResult defined in trait Parsers; rename the class to something else"

[error] /Users/roberto/guardian/frontend/article/app/model/ParseBlockId.scala:10:16: shadowing a nested class of a parent is deprecated but trait ParseResult shadows class ParseResult defined in trait Parsers; rename the class to something else
[error]   sealed trait ParseResult { def toOption: Option[String] }
[error]                ^

ParseBlockId extends RegexParsers, which itself extends scala.util.parsing.combinator.Parsers, a class that has a nested class called ParseResult inside it! So we don't want to have a new nested class called ParseResult inside ParseBlockId - best to rename it.

[OllysCoding]

+1 LGTM

[prout-bot]

Seen on PROD (merged by @ioannakok 11 minutes and 47 seconds ago)

• Check your changes on www.theguardian.com ✔️
• Keep an eye on the deploy dashboard 📉