Scala 2.13: Natural arg-order calling storeJsonBody #25333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scala 2.13 doesn't like the way the code was previously calling `commercial.controllers.Analytics.storeJsonBody()` - effectively, the first 3 arguments, then the last 2 implicit arguments, and then the _middle_ non-implicit `analytics: String` argument. Although this worked in Scala 2.12, in Scala 2.13, this error was raised: ``` /Users/ioanna_kokkini/Projects/frontend/commercial/app/controllers/PrebidAnalyticsController.scala:16:43: Cannot find any HTTP Request here [error] val stream = Analytics.storeJsonBody(Switches.prebidAnalytics, prebidAnalyticsStream, log) _ [error] ``` "Cannot find any HTTP Request here" comes from the implicit `play.api.mvc.Request` not being found by the Scala 2.13 compiler, which I guess was a little confused by the method parameter order. https://github.com/playframework/playframework/blob/59c907fae50481b5c2b8c4313f3aedd39d293d62/core/play/src/main/scala/play/api/mvc/Request.scala#L27-L28 The fix is to just inline the code a bit, and supply the _middle_ `analytics: String` argument in it's natural 2nd position, and allow the compiler to then find the last pair of implicit arguments. Co-authored-by: Ioanna Kokkini <ioanna.kokkini@guardian.co.uk>
rtyley
deleted the
call-storeJsonBody-with-natural-arg-order-for-scala-2.13
branch
|
Seen on PROD (merged by @rtyley 1 hour, 8 minutes and 12 seconds ago)
|
rtyley
added
the
Scala 2.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scala 2.13 doesn't like the way the code was previously calling
commercial.controllers.Analytics.storeJsonBody()- effectively, the first 3 arguments, then the last 2 implicit arguments, and then the middle non-implicitanalytics: Stringargument. Although this worked in Scala 2.12, in Scala 2.13, this error was raised:"Cannot find any HTTP Request here" comes from the implicit
play.api.mvc.Requestnot being found by the Scala 2.13 compiler, which I guess was confused by the method parameter order!The fix is to just inline the code a bit, and supply the middle
analytics: Stringargument in it's natural 2nd position,and allow the compiler to then find the last pair of implicit arguments.