Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR updates SHQ to Scala 2.13.x. We have already taken care of all the dependencies in previous PRs (except for Janus config tools, which is bumped here because it is not cross-compiled). Here we do the actual upgrade and address the syntax changes. The changes which impacted us (which should be split into separate commits) were:
()
deprecatedmapValues
returning aMapView
def run {
->def run: Unit = {
'
tick for SymbolsreplaceAllLiterally
deprecatedI think most of these were non-controversial. For the right-biased Eithers change I also identified a dependency we could remove (scalatestplus-play), which was bringing in an older version of scalatest, which didn't have the appropriate EitherValues helper.
What is the value of this?
Keeping up to date with language version and deps, with all the benefit that usually brings
Will this require CloudFormation and/or updates to the AWS StackSet?
No
Will this require changes to config?
No
Any additional notes?
Everything passes locally, and I've tested the web app. I have not manually tested the lambda(s), but I think those need addressing separately as they haven't been updated for a while.