Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Scala 2.13.x #422

Merged
merged 9 commits into from
Mar 4, 2022
Merged

Update to Scala 2.13.x #422

merged 9 commits into from
Mar 4, 2022

Conversation

jfsoul
Copy link
Contributor

@jfsoul jfsoul commented Mar 3, 2022

What does this change?

This PR updates SHQ to Scala 2.13.x. We have already taken care of all the dependencies in previous PRs (except for Janus config tools, which is bumped here because it is not cross-compiled). Here we do the actual upgrade and address the syntax changes. The changes which impacted us (which should be split into separate commits) were:

  • Auto application of () deprecated
  • Moving of converters for Java types
  • A single pattern match was identified as non-exhaustive (technically it already was exhaustive, but maybe scala 2.13 can't tell that) 🤷‍♂️
  • mapValues returning a MapView
  • Procedure syntax deprecation i.e. def run { -> def run: Unit = {
  • Deprecation of ' tick for Symbols
  • replaceAllLiterally deprecated
  • Either is now right-biased

I think most of these were non-controversial. For the right-biased Eithers change I also identified a dependency we could remove (scalatestplus-play), which was bringing in an older version of scalatest, which didn't have the appropriate EitherValues helper.

What is the value of this?

Keeping up to date with language version and deps, with all the benefit that usually brings

Will this require CloudFormation and/or updates to the AWS StackSet?

No

Will this require changes to config?

No

Any additional notes?

Everything passes locally, and I've tested the web app. I have not manually tested the lambda(s), but I think those need addressing separately as they haven't been updated for a while.

@jfsoul jfsoul requested review from jorgeazevedo and a team March 3, 2022 16:53
Copy link
Member

@akash1810 akash1810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jfsoul jfsoul merged commit a4e4e88 into main Mar 4, 2022
@jfsoul jfsoul deleted the js/scala-2-13 branch March 4, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants