Add package in import when Scala 2.13 compiler gets confused #25368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannakok
force-pushed
the
scala-2.13/add-package-to-import
branch
from
ff0a2c4
to
dddef6f
Compare
rtyley
approved these changes
Aug 11, 2022
ioannakok
changed the title
ioannakok
force-pushed
the
scala-2.13/add-package-to-import
branch
from
dddef6f
to
7b32253
Compare
Scala 2.13 hets confused when deciding which class to import so in some cases we have to also specify the package.
For example, in the following case the compiler thinks we are trying to use `com.google.api.ads.admanager.axis.v202108.CustomTargetingService`.
```
[error] /Users/ioanna_kokkini/Projects/frontend/admin/app/dfp/DataMapper.scala:47:36: value targetingKey is not a member of com.google.api.ads.admanager.axis.v202108.CustomTargetingService
[error] customTargetingService.targetingKey(session)(criterion.getKeyId),
[error]
```
So we have to explicitly add the package in front of the class we are trying to use. Instead of:
```
class DataMapper(
adUnitService: AdUnitService,
placementService: PlacementService,
customTargetingService: CustomTargetingService,
customFieldService: CustomFieldService,
)
```
we do:
```
class DataMapper(
adUnitService: AdUnitService,
placementService: dfp.PlacementService,
customTargetingService: dfp.CustomTargetingService,
customFieldService: dfp.CustomFieldService,
)
```
Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>
ioannakok
force-pushed
the
scala-2.13/add-package-to-import
branch
from
7b32253
to
7ee5023
Compare
|
Seen on PROD (merged by @ioannakok 6 hours and 7 minutes ago)
|
rtyley
added
the
Scala 2.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scala 2.13 hets confused when deciding which class to import so in some cases we have to also specify the package.
For example, in the following case the compiler thinks we are trying to use
com.google.api.ads.admanager.axis.v202108.CustomTargetingService.So we have to explicitly add the package in front of the class we are trying to use. Instead of:
we do:
Co-authored-by: Roberto Tyley roberto.tyley@guardian.co.uk
Pulled from the mega-PR: #25190