-
Notifications
You must be signed in to change notification settings - Fork 554
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add package in front of class to avoid compiler confusion
Scala 2.13 hets confused when deciding which class to import so in some cases we have to also specify the package. For example, in the following case the compiler thinks we are trying to use `com.google.api.ads.admanager.axis.v202108.CustomTargetingService`. ``` [error] /Users/ioanna_kokkini/Projects/frontend/admin/app/dfp/DataMapper.scala:47:36: value targetingKey is not a member of com.google.api.ads.admanager.axis.v202108.CustomTargetingService [error] customTargetingService.targetingKey(session)(criterion.getKeyId), [error] ``` So we have to explicitly add the package in front of the class we are trying to use. Instead of: ``` class DataMapper( adUnitService: AdUnitService, placementService: PlacementService, customTargetingService: CustomTargetingService, customFieldService: CustomFieldService, ) ``` we do: ``` class DataMapper( adUnitService: AdUnitService, placementService: dfp.PlacementService, customTargetingService: dfp.CustomTargetingService, customFieldService: dfp.CustomFieldService, ) ``` Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>
- Loading branch information
Showing
5 changed files
with
10 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters