Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-scala 2.13: bump nscala time #24775

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Pre-scala 2.13: bump nscala time #24775

merged 1 commit into from
Mar 17, 2022

Conversation

DavidLawes
Copy link
Contributor

What does this change?

In advance of updating the scala version we want to update as many dependencies as possible to be compatible with both 2.12 and 2.13.

We tried updating frontend scala to 2.13. One of the compilation errors was from nscala-time. This change bumps the library to the latest version which is now compatible with both 2.12 and 2.13.

Does this change need to be reproduced in dotcom-rendering ?

  • No
  • Yes (please indicate your plans for DCR Implementation)

Screenshots

N/A

What is the value of this and can you measure success?

Checklist

Does this affect other platforms?

  • AMP
  • Apps
  • Other (please specify)

Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?

  • No
  • Yes (please give details)

Does this change break ad-free?

  • No
  • It did, but tests caught it and I fixed it
  • It did, but there was no test coverage so I added that then fixed it

Does this change update the version of CAPI we're using?

Accessibility test checklist

Tested

  • Locally
  • On CODE (optional)

@DavidLawes DavidLawes added the Scala 2.13 See https://github.com/guardian/maintaining-scala-projects/issues/2 label Mar 17, 2022
@DavidLawes DavidLawes linked an issue Mar 17, 2022 that may be closed by this pull request
@DavidLawes DavidLawes marked this pull request as ready for review March 17, 2022 14:36
@DavidLawes DavidLawes requested a review from a team as a code owner March 17, 2022 14:36
Copy link
Member

@AshCorr AshCorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DavidLawes DavidLawes changed the title bump nscala time Pre-scala 2.13: bump nscala time Mar 17, 2022
@DavidLawes DavidLawes merged commit 612580d into main Mar 17, 2022
@DavidLawes DavidLawes deleted the dlawes/update-nscala-time branch March 17, 2022 14:45
@prout-bot prout-bot added Pending-on-PROD and removed Scala 2.13 See https://github.com/guardian/maintaining-scala-projects/issues/2 labels Mar 17, 2022
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @DavidLawes 12 minutes and 52 seconds ago)

@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @DavidLawes 13 minutes and 12 seconds ago)

@ioannakok ioannakok mentioned this pull request Aug 23, 2022
2 tasks
@rtyley rtyley added the Scala 2.13 See https://github.com/guardian/maintaining-scala-projects/issues/2 label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scala 2.13 See https://github.com/guardian/maintaining-scala-projects/issues/2 Seen-on-PROD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nscala time
4 participants