-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.12.0 #20930
Merged
Merged
Release 3.12.0 #20930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master into develop & Set version to 3.12.0-develop
Co-authored-by: Gabriel Henriques <gabriel.henriques@rocket.chat>
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz> Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
…ading Instead of [Object][Object] (#20305)
Co-authored-by: Douglas Fabris <deefabris@gmail.com>
…Chats list (#20320) * fix capitalized "All" to "all" value. * fix date filtering issue. * refactor client and server to accept only 'from' and 'to' dates to list rooms. * set previous date limit to selected date on 'to' field. * permitting users to filter date and hour selecting only 'start' date/time. * Revert "permitting users to filter date and hour selecting only 'start' date/time." This reverts commit a48f0ab. * set a specific date format to server side read properly. * check on the server side if dates are valid. * Revert "check on the server side if dates are valid." This reverts commit 5a10476. * Code style improvements. * Revert unnecessary changes. Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com>
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Co-authored-by: Gabriel Henriques <gabriel.henriques@rocket.chat> Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
Co-authored-by: Gabriel Henriques <gabriel.henriques@rocket.chat> Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
Project Name: Rocket.Chat Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat User: Robot LingoHub Easy language translations with LingoHub 🚀 Co-authored-by: Robot LingoHub <robot@lingohub.com>
sampaiodiego
force-pushed
the
release-3.12.0
branch
from
February 28, 2021 07:17
b7150f7
to
59524a9
Compare
rodrigok
approved these changes
Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-02-27 · 5 🎉 · 17 🚀 · 74 🐛 · 30 🔍 · 29 👩💻👨💻
Engine versions
12.18.4
6.14.8
3.4, 3.6, 4.0
1.23.0
🎉 New features
Button to unset Slackbridge's importIds (#20549)
Cloud Workspace bridge (#20838)
Adds the new CloudWorkspace functionality.
It allows apps to request the access token for the workspace it's installed on, so it can perform actions with other Rocket.Chat services, such as the Omni Gateway.
Cloud workspace bridge Rocket.Chat.Apps-engine#382
Header with Breadcrumbs (#20609)
Statistics about language usage (#20832)
track what languages get picked the most as preferred ui language.
useUserData Hook (#20584)
🚀 Improvements
Add symbol to indicate apps' required settings in the UI (#20447)
Apps are able to define required settings. These settings should not be left blank by the user and an error will be thrown and shown in the interface if an user attempts to save changes in the app details page leaving any required fields blank;
A sign (*) is added to the label of app settings' fields that are required so as to highlight the fields which must not be left blank.
Add visual validation on users admin forms (#20308)
Added auto-focus for better user-experience. (#19954 by @Darshilp326)
Added disable button check for send invite button (#20337 by @yash-rajpal)
Added Disable check for send invite button. If the text field is empty button would be disabled, and after any valid email is filled, button would get enabled
Added key prop, removing unwanted warnings (#20473 by @yash-rajpal)
Removes warnings listed on the issue
Added Markdown links to custom status. (#20470 by @yash-rajpal)
Added markdown links to user's custom status.
Adds tooltip for sidebar header icons (#19934 by @RonLek)
Previously the header icons in the sidebar didn't show a tooltip when hovered over. This PR fixes that.
Better Presentation of Blockquotes (#20750 by @aditya-mitra)
Changed the values of
margin-top
andmargin-bottom
for first and last childs in blockquotes to increase readability.Before
Now
Change header based on room type (#20612)
It brings more flexibility, allowing us to use different hooks and different components for each header
Check Livechat message length through REST API endpoint (#20366 by @yash-rajpal)
Added checks for message length for livechat message api, it shouldn't exceed specified character limit.
Customize announcement (#20793 by @im-adithya)
Included new variables in customizable ones
Make message field required in Omnichannel Triggers form (#20827)
New chat started system message for Omnichannel conversations (#20814)
Replace react-window for react-virtuoso package (#20392)
Remove:
react-window
react-window-infinite-loader
simplebar-react
Include:
react-virtuoso
rc-scrollbars
Rewrite Call as React component (#19778)
Selector for default custom oauth key field (#20573 by @paulobernardoaf)
Update rc-scrollbars (#20733)
🐛 Bug fixes
Add debouncing to add users search field. (#20297 by @Darshilp326)
BEFORE
add-user-issue.mp4
AFTER
Add-user-pr.mp4
Add tooltips to Thread header buttons (#20456 by @aKn1ghtOut)
Added tooltips to "Expand" and "Follow Message"/"Unfollow Message" in ThreadView for coherency.
Added Bio Structure for UserCard, rendering Skeleton View on loading Instead of [Object][Object] (#20305 by @yash-rajpal)
Added Bio Structure for rendering Skeleton View on loading UserCard.
Added check for view admin permission page (#20403 by @yash-rajpal)
Admin Permission page was visible to all, if you add admin/permissions after the base url. This should not be visible to all user, only people with certain permissions should be able to see this page.
I am also able to see permissions page for open workspace of Rocket chat.
Adding the accidentally deleted tag template, used by other templates (#20772 by @yash-rajpal)
Adding back accidentally deleted tag Template.
Admin cannot clear user details like bio or nickname (#20785 by @yash-rajpal)
When the API users.update is called to update user data, it passes data to saveUser function. Here before saving data like bio or nickname we are checking if they are available or not. If data is available then we are saving it, but we are not doing anything when data isn't available.
So unsetting data if data isn't available to save. Will also fix bio and other fields. :)
Admin Panel pages not visible in Safari (#20912)
Announcement with multiple lines fixed. (#20381 by @yash-rajpal)
Announcements with multiple lines used to break UI for announcements bar. Fixed it by replacing all break lines in announcement with empty space (" ") . The announcement modal would work as usual and show all break lines.
Atlassian Crowd login with 2FA enabled (#20834)
Attachment download from title fixed (#20585 by @yash-rajpal)
Added target = '_self' to attachment link, this seems to fix the problem, without this attribute, error page is displayed.
Blank Personal Access Token Bug (#20193 by @RonLek)
Adds error when personal access token is blank thereby disallowing the creation of one.
Screencast.from.Wednesday.13.January.2021.09.52.53.IST.mp4
CAS login failing due to TOTP requirement (#20840)
Changed password input field for password access in edit room info. (#20356 by @Darshilp326)
Password field would be secured with asterisks in edit room info
Password-access-pr.mp4
.
Channel mentions showing user subscribed channels twice (#20484 by @Darshilp326)
Channel mention shows user subscribed channels twice.
channel-mention-pr.mp4
CORS config not accepting multiple origins (#20696)
always include only one value in access-control-allow-origin
Custom OAuth provider creation from env vars (#20014 by @pierreozoux)
Default Attachments - Remove Extra Margin in Field Attachments (#20618 by @aditya-mitra)
A large amount of unnecessary margin which existed in the Field Attachments inside the
DefaultAttachments
has been fixed.Earlier
Now
Default Attachments - Show Full Attachment.Text with Markdown (#20606 by @aditya-mitra)
Removed truncating of text in
Attachment.Text
.Added
Attachment.Text
to be parsed to markdown by default.Earlier
Now
Don't ask again not rendering (#20745)
Download buttons on desktop app and CDN being ignored (#20820)
E2E issues (#20704)
ESLint Warning - react-hooks/exhaustive-deps (#20586 by @aditya-mitra)
Added the required dep (
label
) inuseMemo
to fix eslint warningreact-hooks/exhaustive-deps
.Event emitter warning (#20663)
External systems not being able to change Omnichannel Inquiry priorities (#20740)
Due to a wrong property name, external applications were not able to change the priority of Omnichannel Inquires.
Feedback on bulk invite (#20339 by @aKn1ghtOut)
Resolved structure where no response was being received. Changed from callback to async/await.
Added error in case of empty submission, or if no valid emails were found.
gitIssueBulkInvite-2021-01-24_02.24.08.mp4
Filters are not being applied correctly in Omnichannel Current Chats list (#20320)
Before
After
Fix Empty highlighted words field (#20329 by @yash-rajpal)
Able to Empty the highlighted text field in preferences
Gif images aspect ratio on preview (#20654)
height prop on departments agents table (#20833)
Hide system messages not working on second save (#20679)
Icon for OTR messages (#20713)
Incorrect display of "Reply in Direct Message" in MessageAction (#17968 by @abrom)
[FIX] Incorrect display of "Reply in Direct Message" in MessageAction
Increasing unread counter twice for new threads in DMs or with mentions (#20666)
Links not opening in new tabs (#20651)
List of Omnichannel triggers is not listing data (#20624)
Before
After
Livechat bridge permission checkers (#20653)
Update to latest patch version of the Apps-Engine with a fix for the Livechat bridge, as seen in Fix missing permission checkers Rocket.Chat.Apps-engine#379
Mark messages inside a thread as unread (#20726 by @im-adithya)
Added threads to mark unread action button.
Markdown prop variants (#20767)
A new prop variants on Markdown component: inline and inlineWithoutBreaks
Message payload from
__my_messages__
stream (#20801)Missing height on departments agents table (#20739)
Missing setting to control when to send the ReplyTo field in email notifications (#20744)
Add a new setting ("Add Reply-To header") in the Email settings' page to control when the Reply-To header is used in e-mail notifications;
The new setting is turned off (
false
value) by default.New Integration page was not being displayed (#20670 by @yash-rajpal)
Notification worker stopping on error (#20605)
OAuth Login not working on Firefox (#20722)
Omnichannel agents are unable to access the chat queue on the sidebar (#20830)
Omnichannel Routing System not assigning chats to Bot agents (#20662)
The
Omnichannel Routing System
is no longer assigning chats tobot
agents when thebot
agent is the default agent of the inquiry.Open Visitor Info when omnichannel chat was open (#20868)
OTR issue (#20592)
Since the users are not being stored at the user collection anymore (thats a good thing actually), there is no such record to to fetch and show the username.
Quoted messages from message links when user has no permission (#20815)
Regenerate token modal on top of 2FA modal (#20798)
Regular status mutating custom status (#20613)
Remove duplicate getCommonRoomEvents() event binding for pinnedMessages (#20179 by @aKn1ghtOut)
The getCommonRoomEvents() returned functions were bound to the pinnedMessages template twice. This was causing some bugs, as detailed in the Issue mentioned below.
Remove duplicate getCommonRoomEvents() event binding for starredMessages (#20185 by @aKn1ghtOut)
The getCommonRoomEvents() returned functions were bound to the starredMessages template twice. This was causing some bugs, as detailed in the Issue mentioned below.
I removed the top events call that only bound the getCommonRoomEvents(). Therefore, only one call for the same is left, which is at the end of the file. Having the events bound just once removes the bugs mentioned.
Remove warning problems from console (#20800)
Removed tooltip in kebab menu options. (#20498 by @Darshilp326)
Removed tooltip as it was not needed.
kebab-menu-pr.mp4
Retry icon comes out of the div (#20390 by @im-adithya)
Changed the height of the div container.
Room owner not being able to override global retention policy (#20727)
use correct permissions to check if room owner can override global retention policy
Room Scroll to Bottom (#20649)
Room's last message's update date format on IE (#20680)
The proposed change fixes a bug when updates the cached records on Internet Explorer and it breaks the sidebar as shown on the screenshot below:
Save user password and email from My Account (#20737)
Security Hotfix (https://docs.rocket.chat/guides/security/security-updates)
Selected hide system messages would now be viewed in vertical bar. (#20358 by @Darshilp326)
All selected hide system messages are now in vertical Bar.
system-message-issue.mp4
Selected messages don't get unselected (#20408 by @im-adithya)
Rocket.Chat.-.Google.Chrome.2021-01-26.17-46-20.mp4
Sending user to home after logging in from resume token query param (#20720)
Do not redirect to
/home
anymore after logging in withresumeToken
.Server-side marked parsing (#20665)
Several Slack Importer issues (#20216)
Fix: Slack Importer crashes when importing a large users.json file
Fix: Slack importer crashes when messages have invalid mentions
Skip listing all users on the preparation screen when the user count is too large.
Split avatar download into a separate process.
Update room's last message when the import is complete.
Prevent invalid or duplicated channel names
Improve message error handling.
Reduce max allowed BSON size to avoid possible issues in some servers.
Improve handling of very large channel files.
star icon was visible after unstarring a message (#19645 by @bhavayAnand9)
Threads Issues (#20725)
Typo in Message Character Limit (#20426 by @aditya-mitra)
Changed the spelling of Characther to Character
Unset tshow on deleted messages (#20444 by @aKn1ghtOut)
When setting 'Message_ShowDeletedStatus' is set to true, deleting a message with
tshow: true
causes a bug on the frontend. This issue should, however, never be logically possible as a 'removed' message should not have tshow anyway. Hence, this PR unsets that when the message is set to "Message Removed".Update NPS banner when changing score (#20611)
User statuses in admin user info panel (#20341 by @RonLek)
Modifies user statuses in admin info panel based on their actual status instead of their
statusConnection
. This enables correct and consistent change in user statuses.Also, bot users having status as online were classified as offline, with this change they are now correctly classified based on their corresponding statuses.
Screencast.from.Sunday.24.January.2021.12.38.23.IST.mp4
Users autocomplete showing duplicated results (#20481 by @Darshilp326)
Added new query for outside room users so that room members are not shown twice.
mention-user-pr.mp4
🔍 Minor changes
Added toast message after deleting file. (#20661 by @Darshilp326)
delete-files-pr.mp4
Added types to Emitters (#20819)
Bump Livechat Widget (#20843)
Update Livechat version to
1.8.0
.Chore: Change error message when marking empty chat as unread (#20250)
Chore: Disable Sessions Aggregates tests locally (#20607)
Disable Session aggregates tests in local environments
For context, refer to: [FIX] Unit tests timeout on linux. #20161
Chore: Improve performance of messages’ watcher (#20519)
Chore: Push correct Docker tag of service images (#20706)
Chore: Remove node-sprite-generator dependency (#20545)
Chore: Try building micro services early on CI (#20046)
Chore: update RC with the latest fuselage-polyfills (#20709)
Exclude user's own password from /me endpoint (#20735)
Fix: Add network observe plug to snap (#20852)
Improve: Add more API tests (#20738)
Add end-to-end tests for untested endpoints.
Language update from LingoHub 🤖 on 2021-02-15Z (#20757)
Language update from LingoHub 🤖 on 2021-02-22Z (#20853)
Merge master into develop & Set version to 3.12.0-develop (#20533)
Mixed client and server code on Storybook (#20799)
For Storybook to work, we've mocked all modules under
**/server/
, thus making them suitable to hold all code that refers Node.js modules. This implies some duplication, betweenclient/
andserver/
modules, mediated by modules underlibs/
.Regression: Discussions inside direct messages not rendering (#20652)
Regression: Fix loadHistory method being called multiple times (#20826)
Regression: Fix notification worker not firing (#20829)
Regression: Fix scopes not being provided to getWorkspaceAccessToken (#20871)
Regression: Header Styles (#20616)
Regression: Keep user custom status after change presence (#20869)
Regression: Messages not being encrypted E2E (#20922)
Regression: Prevent Message Attachment rendering (#20860)
Remove
uiKitText
reference (#20625)Rewrite: CreateChannel modal component (#20617)
RoomFiles hook (#20550)
Update Apps-Engine version (#20921)
Update the Apps-Engine to latest version for the release.
Wrong method used while starring (#20508 by @im-adithya)
Changed the method from pinMessage to starMessage
👩💻👨💻 Contributors 😍
👩💻👨💻 Core Team 🤓