Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] useUserData Hook #20584

Merged
merged 2 commits into from
Feb 3, 2021
Merged

[NEW] useUserData Hook #20584

merged 2 commits into from
Feb 3, 2021

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Feb 3, 2021

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo requested a review from a team February 3, 2021 14:59
@lgtm-com
Copy link

lgtm-com bot commented Feb 3, 2021

This pull request introduces 1 alert when merging a902fd5 into 61ca8bf - view on LGTM.com

new alerts:

  • 1 for Invocation of non-function

@aditya-mitra
Copy link
Contributor

Just a question, can we use this hook to get the custom user status text?

I had made Pull Request #20257 (Open) a while back where I had to make a few changes to get the live user status text.

@ggazzo
Copy link
Member Author

ggazzo commented Feb 3, 2021

hey @aditya-mitra
sure! I have created this hook thinking about how to solve the issue you mentioned!

(actually we have more issues related with that we will be solved having that hook)

@aditya-mitra
Copy link
Contributor

aditya-mitra commented Feb 3, 2021

@ggazzo
Can I commit and pull request on this branch - chore/userPresence so that we can resolve issue #20197 with lesser changes required?
( I will make a fresh pull request for that and do it today. )
( I will also close PR #20257 as it is outdated now. )

Or should I wait until this pull request is merged?

Thank you.

@ggazzo
Copy link
Member Author

ggazzo commented Feb 3, 2021

Can I commit and pull request on this branch - chore/userPresence so that we can resolve issue #20197 with lesser changes required?
( I will make a fresh pull request for that and do it today. )
( I will also close PR #20257 as it is outdated now. )

Or should I wait until this pull request is merged?

Thank you.

hm... wait a minute I will merge this one today/tomorrow no more, I like the idea to keep it in different prs, AND I think I would make change few things in your pr if I could

@aditya-mitra
Copy link
Contributor

Sure.
No problem.

@RocketChat RocketChat deleted a comment from lgtm-com bot Feb 3, 2021
@ggazzo ggazzo merged commit 8b23ebd into develop Feb 3, 2021
@ggazzo ggazzo deleted the chore/userPresence branch February 3, 2021 19:37
@sampaiodiego sampaiodiego mentioned this pull request Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants