[FIX] Room Header - UserStatusText to be displayed in Direct Chat #20593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-rajpal
reviewed
Feb 4, 2021
client/views/room/Header/Header.js
Outdated
| const liveOtherUserStatusText = useUserData(otherUserQuery?.userId)?.statusText; | ||
|
|
||
| // if the other is offline, then liveOtherUserStatusText is undefined | ||
| const { value: data } = useEndpointData('users.info', otherUserQuery); |
There was a problem hiding this comment.
But for a user who is online, it would fetch the status twice. Perhaps we can put a check here, if liveOtherUserStatusText is undefined then pull from endpoint. Otherwise, getting status from enpoint is unnecessary.
Also I think useUserData() should provide userstatus in all cases, otherwise whats the benefit of using it? In that case we can always use endpoint.
aditya-mitra
force-pushed
the
aditya-mitra-dm-status-text-hook
branch
from
bfb3549
to
5549b2a
Compare
|
@aditya-mitra @yash-rajpal Guys, we really appreciate your efforts in helping us. But we cannot move forward with this PR because we were working that if a more complex approach that will advance a future job for us. Thank you so much! Btw this issue will be fixed in this PR: #20612 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
In a 2-person direct message, the status of the other user could not be seen in the Header.
It has been fixed by fetching the other user's status-text in a 2-person direct message room.
updated.user-status-text.with.hook.mp4
Issue(s)
Closes #20197
Steps to test or reproduce
Same as mentioned in #20197
Further comments
This Pull Request introduces the same feature as in #20257 , but with lesser changes.
As Pull Request #20584 introduces the new
useUserDatahook it was possible to get the live user status text in a single file change.