Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Several Slack Importer issues #20216

Merged
merged 13 commits into from
Feb 19, 2021
Merged

[FIX] Several Slack Importer issues #20216

merged 13 commits into from
Feb 19, 2021

Conversation

pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Jan 15, 2021 •
edited by sampaiodiego
Loading

  • Fix: Slack Importer crashes when importing a large users.json file
  • Fix: Slack importer crashes when messages have invalid mentions
  • Skip listing all users on the preparation screen when the user count is too large.
  • Split avatar download into a separate process.
  • Update room's last message when the import is complete.
  • Prevent invalid or duplicated channel names
  • Improve message error handling.
  • Reduce max allowed BSON size to avoid possible issues in some servers.
  • Improve handling of very large channel files.

Proposed changes (including videos or screenshots)

  • Fix: Slack Importer crashes when importing a large users.json file
  • Fix: Slack importer crashes when messages have invalid mentions
  • Skip listing all users on the preparation screen when the user count is too large.
  • Split avatar download into a separate process.
  • Update room's last message when the import is complete.
  • Prevent invalid or duplicated channel names
  • Improve message error handling.
  • Reduce max allowed BSON size to avoid possible issues in some servers.
  • Improve handling of very large channel files.

Issue(s)

Closes #20691

Steps to test or reproduce

Further comments

@pierre-lehnen-rc pierre-lehnen-rc changed the title [FIX] Slack Importer crashing when importing a large users.json file [FIX] Several Slack Importer issues. Feb 4, 2021
@sampaiodiego sampaiodiego added this to the 3.12.0 milestone Feb 17, 2021
@sampaiodiego sampaiodiego self-requested a review February 17, 2021 20:15
@sampaiodiego sampaiodiego merged commit 77873bd into develop Feb 19, 2021
@sampaiodiego sampaiodiego deleted the fix.large-slack-user-import branch February 19, 2021 20:40
@sampaiodiego sampaiodiego changed the title [FIX] Several Slack Importer issues. [FIX] Several Slack Importer issues Feb 19, 2021
gabrieleiro pushed a commit that referenced this pull request Feb 19, 2021
@pierre-lehnen-rc @gabrieleiro
[FIX] Several Slack Importer issues (#20216)
227af8b
gabrieleiro pushed a commit that referenced this pull request Feb 20, 2021
@pierre-lehnen-rc @gabrieleiro
[FIX] Several Slack Importer issues (#20216)
f37839b
@sampaiodiego sampaiodiego mentioned this pull request Feb 28, 2021
Merged
pierre-lehnen-rc added a commit that referenced this pull request Apr 7, 2021
@pierre-lehnen-rc
Merge branch 'develop' into ts-importers
91be6ad 
Removed changes from PR #20216 that were made on the old structure - they need to be re-implemented on the new slack importer.

# Conflicts:
#	app/importer-slack/server/importer.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

Hotchillee - Slack import making content disappear
2 participants
@pierre-lehnen-rc @sampaiodiego