[FIX] Retry icon comes out of the div #20390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of changing the sizes, wouldn't a simple padding in the placeholder suffice? |
|
Please, also post screenshots of the fix. Thanks! |
Sure! This seems to be better indeed!! |
|
This pull request introduces 16 alerts when merging fa495c6 into 54e0a71 - view on LGTM.com new alerts:
|
|
@dougfabris @ggazzo can anyone please review this? Thanks! |
tiagoevanp
requested changes
Feb 12, 2021
tiagoevanp
previously approved these changes
Feb 13, 2021
|
Thank you @tiagoevanp! Removed {...dimensions} as well! |
|
This pull request introduces 1 alert when merging 4728cc0 into 4f05c55 - view on LGTM.com new alerts:
|
tiagoevanp
approved these changes
Feb 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Changed the height of the div container.
Issue(s)
This PR closes #20389
Earlier
Now
Note
Due to different image sizes, the widths are different here in the image but actually the boxes are of the same width and the retry icon and text are of the same size.