Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] star icon was visible after unstarring a message #19645

Merged
merged 3 commits into from
Feb 18, 2021

Conversation

bhavayAnand9
Copy link
Contributor

@bhavayAnand9 bhavayAnand9 commented Nov 21, 2020

Proposed changes

PR contains a fix for a bug where
when a user unstar a message, the star icon was still visible
if a user stars a message in a direct chat, the user at the other end would also see a star icon.

Issue(s)

Closes #19608

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Fix: Starred messages can't be unstarred

Further comments

@bhavayAnand9
Copy link
Contributor Author

Hi! @ggazzo Could you please review this PR? Thanks

@ggazzo ggazzo merged commit bdcf3bf into RocketChat:develop Feb 18, 2021
@sampaiodiego sampaiodiego mentioned this pull request Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA-Regression: Starred messages can't be unstarred.
5 participants