Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] Check Livechat message length through REST API endpoint #20366

Merged
merged 6 commits into from
Feb 15, 2021
Merged

[IMPROVE] Check Livechat message length through REST API endpoint #20366

merged 6 commits into from
Feb 15, 2021

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Jan 25, 2021 •
edited
Loading

  • I have read the Contributing Guide -
  • I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Added checks for message length for livechat message api, it shouldn't exceed specified character limit.

Issue(s)

fixes #20364 #20365

Steps to test or reproduce

Check issue

Further comments

Screenshot of error returned if message length exceeds specified limit.
image

@yash-rajpal
Copy link
Member Author

By mistake had a commit from other PR here, so reverted it.

@yash-rajpal
Copy link
Member Author

Done @renatobecker .
Thanks :)

@renatobecker renatobecker changed the title [FIX] Checking Livechat message length should not exceed specified character limit. [IMPROVE] Check Livechat message length through REST API endpoint Feb 15, 2021
@renatobecker renatobecker added this to the 3.12.0 milestone Feb 15, 2021
@renatobecker renatobecker merged commit 7eae419 into RocketChat:develop Feb 15, 2021
@cuonghuunguyen cuonghuunguyen mentioned this pull request Feb 18, 2021
Closed
@sampaiodiego sampaiodiego mentioned this pull request Feb 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatobecker renatobecker renatobecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

Wrong type for Livechat_message_character_limit when changing its value in /omnichannel/appearance
2 participants
@yash-rajpal @renatobecker