[NEW] Statistics about language usage #20832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieleiro
force-pushed
the
language-statistics
branch
from
07917df
to
0470102
Compare
rodrigok
requested changes
Feb 20, 2021
| @@ -31,6 +31,16 @@ const setPrometheusData = async () => { | |||
| metrics.ddpAuthenticatedSessions.set(authenticatedSessions.length); | |||
| metrics.ddpConnectedUsers.set(_.unique(authenticatedSessions.map((s) => s.userId)).length); | |||
|
|
|||
| // Apps metrics | |||
There was a problem hiding this comment.
moved this up because it was not running if no statistics were found https://github.com/RocketChat/Rocket.Chat/pull/20832/files#diff-d5557cb19a93c53e1e732cf0f6ca3ef772654b5a9fc40fa9f92092f6d304d196R45
| @@ -4,7 +4,7 @@ export class Statistics extends Base { | |||
| constructor() { | |||
| super('statistics'); | |||
|
|
|||
| this.tryEnsureIndex({ createdAt: 1 }); | |||
| this.tryEnsureIndex({ createdAt: -1 }); | |||
There was a problem hiding this comment.
the only find using this index was findLast and it sorts on reverse order
rodrigok
previously approved these changes
Feb 21, 2021
rodrigok
changed the title
rodrigok
approved these changes
Feb 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
track what languages get picked the most as preferred ui language.
Issue(s)
Steps to test or reproduce
Further comments