Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Download buttons on desktop app and CDN being ignored #20820

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Feb 19, 2021

Proposed changes (including videos or screenshots)

Issue(s)

closes #20674
closes #20543

Steps to test or reproduce

Further comments

@ggazzo ggazzo requested a review from a team February 19, 2021 03:39
@ggazzo ggazzo added this to the 3.12.0 milestone Feb 19, 2021
@ggazzo ggazzo merged commit 269fd3f into develop Feb 22, 2021
@ggazzo ggazzo deleted the fix/download-attachments branch February 22, 2021 13:55
@sampaiodiego sampaiodiego mentioned this pull request Feb 28, 2021
vanhoang1107 pushed a commit to vanhoang1107/Rocket.Chat that referenced this pull request Mar 2, 2021
* rocketchat/master: (134 commits)
  Bump version to 3.12.0
  Bump version to 3.12.0-rc.4
  Revert config ignoreUndefined
  Bump version to 3.12.0-rc.3
  Fix lint
  Security Fixes
  Bump version to 3.12.0-rc.2
  [FIX] Admin Panel pages not visible in Safari (RocketChat#20912)
  Update Apps-Engine version (RocketChat#20921)
  Regression: Messages not being encrypted E2E (RocketChat#20922)
  Fix: Add network observe plug to snap (RocketChat#20852)
  Language update from LingoHub 🤖 (RocketChat#20853)
  Added types to Emitters (RocketChat#20819)
  Bump version to 3.12.0-rc.1
  Regression: Fix scopes not being provided to getWorkspaceAccessToken (RocketChat#20871)
  Regression: Keep user custom status after change presence (RocketChat#20869)
  [FIX] Markdown prop variants (RocketChat#20767)
  [FIX] Open Visitor Info when omnichannel chat was open (RocketChat#20868)
  Regression: Prevent Message Attachment rendering (RocketChat#20860)
  [FIX] Download buttons on desktop app and CDN being ignored (RocketChat#20820)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rocket.Chat not respecting CDN Domain for Downloads option Links open in internal browser
2 participants