Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links open in internal browser #20543

Closed
LenryNmQ opened this issue Feb 1, 2021 · 19 comments · Fixed by #20820
Closed

Links open in internal browser #20543

LenryNmQ opened this issue Feb 1, 2021 · 19 comments · Fixed by #20820
Assignees

Comments

@LenryNmQ
Copy link

LenryNmQ commented Feb 1, 2021

Description:

If I got a URL in a message, I'll have the link itself, and a preview. If I click on the preview, it will open in my default browser, like it always did. But if I click on the link itself, it opens within the Rocket.Chat window.

Steps to reproduce:

  1. Send a URL in a message
  2. Click on the URL itself - not the preview
  3. It will open in the client

Expected behavior:

Open links in default browser

Actual behavior:

It opens inside the client
Screenshot_20210201_162727

Server Setup Information:

  • Version of Rocket.Chat Server: 3.10.5
  • Operating System: Ubuntu 18.04 LTS
  • Deployment Method: Docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • NodeJS Version: 12.18.4
  • MongoDB Version: 4.0.20

Client Setup Information

  • Desktop App or Browser Version: 3.11
  • Operating System: Tried on Windows 10, Arch Linux and macOS

Additional context

Relevant logs:

@DC7IA
Copy link

DC7IA commented Feb 1, 2021

Can confirm, same desktop version.

@pkev777
Copy link

pkev777 commented Feb 2, 2021

the same for me

@rhikura
Copy link

rhikura commented Feb 2, 2021

And same for me

@nickbroon
Copy link

Dup of #20460 ?

@kaffeeknecht
Copy link

Same in 3.9.7

@PaulVerhoeven1
Copy link

this is quite annoying 😐

@ggazzo ggazzo self-assigned this Feb 3, 2021
@brunobertoldi
Copy link

brunobertoldi commented Feb 4, 2021

A workaround I found is to click using the middle mouse button

Version 3.11.0

@Vkat14
Copy link

Vkat14 commented Feb 5, 2021

Cntrl Key + click opens it in the Browser
Shift Key + Click opens it in a new Rocket Chat Window(using the Internal Browser)

6 out 10 times, i forget to use the cntrl key and end up having to reload the app to clear it. I also noticed the Chat client now lags. You can see it if you try to move the window around. When the app is brought to view from the Minimized or Background state, it take a few seconds for the app the display the contents. You either get a White/Black screen.

We do not manually update the Server and if version 3.11 contains the same problems with links then this may stretch itself out for the whole month of Feb. I am hoping 3.11 resolves performance issues.

@Silimilikim
Copy link

6 out 10 times, i forget to use the cntrl key and end up having to reload the app to clear it.

Instead of reloading the app, you can use Alt+left to go back to the previous screen. More convenient but still...

@Vkat14
Copy link

Vkat14 commented Feb 8, 2021

6 out 10 times, i forget to use the cntrl key and end up having to reload the app to clear it.

Instead of reloading the app, you can use Alt+left to go back to the previous screen. More convenient but still...

Thank you for sharing this.

@cool-tiger
Copy link

6 out 10 times, i forget to use the cntrl key and end up having to reload the app to clear it.

Instead of reloading the app, you can use Alt+left to go back to the previous screen. More convenient but still...

or CMD+[ on mac os

@andreas-monday
Copy link

the problem continues in the version 3.11.1

@robbyoconnor
Copy link
Contributor

robbyoconnor commented Feb 12, 2021

This is weird -- because it does NOT happen on https://open.rocket.chat but it DOES occur on my instance :(

@lelvisl
Copy link

lelvisl commented Feb 12, 2021

but it happens on self-hosted instances. 3.10.5 and higher have this problem.

@ggazzo
Copy link
Member

ggazzo commented Feb 18, 2021

I think that was closed by #20651

@xmedeko
Copy link

xmedeko commented Feb 18, 2021

@ggazzo Which version is the fix scheduled to release?

@ggazzo
Copy link
Member

ggazzo commented Feb 19, 2021

@ggazzo Which version is the fix scheduled to release?

at least 3.12.0 but since its quite annoying, probably at 3.11.2 as well

@marwin1991
Copy link

5.4 and still getting this error

@marwin1991
Copy link

@ggazzo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.