Chore: Remove node-sprite-generator dependency #20545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjoanes
reviewed
Feb 2, 2021
| @@ -1,5 +1,7 @@ | |||
| /* eslint-disable */ | |||
|
|
|||
| // before using this script make sure to run: npm i --no-save node-sprite-generator | |||
|
|
|||
| // node --experimental-modules generateEmojiIndex.mjs | |||
| import fs from 'fs'; | |||
| import nsg from 'node-sprite-generator'; | |||
There was a problem hiding this comment.
I don't want to remove the script itself, but maybe it is a good idea to move it to .scripts folder, since it is not part of the rocket.chat application, it is just a helper script 🤔
ggazzo
approved these changes
Feb 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This dependency is only used by the emoji sprite generator, which is not used that often (maybe it was used only once in a life time) but it adds an annoying error during
meteor npm idue to a missing peer dependency, so I'm proposing removing it and adding a comment on the script it is used to install dependency manually, I hope this change brings peace to everyone trying out building rocket.chat from source.Issue(s)
Steps to test or reproduce
Further comments