[FIX] Blank Personal Access Token Bug #20193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review :) |
|
@RonLek Hey! Thanks for your help. I think it's nice to have either a UI verification on the personal token field blocking to send the form if the user leaves it blank. Are you interested to improve it? |
dougfabris
changed the title
|
@dougfabris Thanks! Made the change. Please take a look :) |
|
@dougfabris @ggazzo what do you think of this one? Looks good? |
dougfabris
approved these changes
Jan 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Adds error when personal access token is blank thereby disallowing the creation of one.
Screencast.from.Wednesday.13.January.2021.09.52.53.IST.mp4
Issue(s)
Closes #20192
Steps to test or reproduce