fixing agent_wait_for_cloud_init e2e test #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagworld9
requested review from
narrieta,
ZhidongPeng and
maddieford
as code owners
nagworld9
commented
Jun 18, 2024
| # override any existing value (the current LISA template does not have any). | ||
| # | ||
| # "getOSProfile": { | ||
| # "generateOsProfile": { |
There was a problem hiding this comment.
lisa template changed, now we should use this function instead of getOSProfile
narrieta
approved these changes
Jun 18, 2024
maddieford
approved these changes
Jun 18, 2024
maddieford
pushed a commit
to maddieford/WALinuxAgent
that referenced
this pull request
Aug 13, 2024
(cherry picked from commit bf45d50)
maddieford
added a commit
that referenced
this pull request
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent lisa changes had bug around use of custom image. So, agent_wait_for_cloud_init test failing.
This pr taking new lisa fix and also addressing new arm template change.
Issue #
PR information
Quality of Code and Contribution Guidelines