wait for provision to complete before install test agent #3094
Conversation
nagworld9
requested review from
narrieta,
ZhidongPeng and
maddieford
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3094 +/- ##
========================================
Coverage 71.89% 71.89%
========================================
Files 110 110
Lines 16395 16395
Branches 2342 2342
========================================
Hits 11788 11788
Misses 4055 4055
Partials 552 552 ☔ View full report in Codecov by Sentry. |
| @@ -85,19 +85,19 @@ echo "Agent Version:" | |||
| $python "$waagent" --version | |||
| echo "Service Status:" | |||
|
|
|||
| # Sometimes the service can take a while to start; give it a few minutes, | |||
| # Sometimes the service can take a while to start and provision completed; give it a few minutes, | |||
There was a problem hiding this comment.
I'd update the comment to describe that we need to wait for the provisioning code before stopping the agent's service to do the test setup
| started=true | ||
| break | ||
| fi | ||
| echo "Waiting for service to start..." | ||
| echo "Waiting for service to complete provision..." |
There was a problem hiding this comment.
"Waiting for agent to complete provisioning."?
| sleep 30 | ||
| done | ||
| if [ $started == false ]; then | ||
| echo "Service failed to start." | ||
| echo "Service failed to complete provision." |
There was a problem hiding this comment.
"Provisioning did not completed in the given timeout (cannot find /var/lib/waagent/provisioned)"?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3094 +/- ##
========================================
Coverage 71.87% 71.87%
========================================
Files 110 110
Lines 16406 16406
Branches 2344 2344
========================================
Hits 11791 11791
Misses 4064 4064
Partials 551 551 ☔ View full report in Codecov by Sentry. |
Description
wait for provision to complete before install test agent.
Issue #
PR information
Quality of Code and Contribution Guidelines