Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait for provision to complete before install test agent #3094

Merged
merged 3 commits into from
Mar 21, 2024
Merged

wait for provision to complete before install test agent #3094

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9dd227
wait for provision to complete
nagworld9 Mar 15, 2024
3977926
address comments
nagworld9 Mar 19, 2024
1955f3c
Merge branch 'develop' into provision-check
nagworld9 Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests_e2e/orchestrator/scripts/install-agent
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,19 +85,19 @@ echo "Agent Version:"
$python "$waagent" --version
echo "Service Status:"

# Sometimes the service can take a while to start; give it a few minutes,
# Sometimes the service can take a while to start and provision completed; give it a few minutes,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd update the comment to describe that we need to wait for the provisioning code before stopping the agent's service to do the test setup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

started=false
for i in {1..6}
do
if service-status $service_name; then
if [[ -f /var/lib/waagent/provisioned ]]; then
started=true
break
fi
echo "Waiting for service to start..."
echo "Waiting for service to complete provision..."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Waiting for agent to complete provisioning."?

sleep 30
done
if [ $started == false ]; then
echo "Service failed to start."
echo "Service failed to complete provision."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Provisioning did not completed in the given timeout (cannot find /var/lib/waagent/provisioned)"?

exit 1
fi

Expand Down
Loading