Ignore network unreachable error in hostname test #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narrieta
requested review from
ZhidongPeng,
nagworld9 and
maddieford
as code owners
added 2 commits
February 29, 2024 13:40
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3074 +/- ##
========================================
Coverage 71.62% 71.62%
========================================
Files 110 110
Lines 16428 16428
Branches 2352 2352
========================================
Hits 11766 11766
Misses 4110 4110
Partials 552 552 ☔ View full report in Codecov by Sentry. |
narrieta
commented
Feb 29, 2024
|
|
||
| return original_popen(systemd_command, *args, **kwargs) |
There was a problem hiding this comment.
if neither of the 2 conditions above are true, systemd_command is undefined
nagworld9
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another variation of network unreachable that needs to be ignored.
This PR exposed a unit test failure and a pylint crash. Fixes are included.