Add keyvault test to daily run + Specify tests suite as a list #3089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narrieta
requested review from
ZhidongPeng,
nagworld9 and
maddieford
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3089 +/- ##
========================================
Coverage 71.89% 71.89%
========================================
Files 110 110
Lines 16395 16395
Branches 2342 2342
========================================
Hits 11788 11788
Misses 4055 4055
Partials 552 552 ☔ View full report in Codecov by Sentry. |
maddieford
reviewed
Mar 11, 2024
maddieford
approved these changes
Mar 11, 2024
nagworld9
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out I forgot to add the keyvault test to the daily runbook.
As we've added more tests to the runbook, listing them as a comma-separate list makes it harder to notice such errors. I changed the test suites to be an array instead, which makes it much easy to read.