-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reset uphold setting for agent service in flatcar distro #3066
Conversation
2387819
to
53c0e5c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3066 +/- ##
===========================================
- Coverage 71.97% 71.64% -0.34%
===========================================
Files 103 110 +7
Lines 15692 16422 +730
Branches 2486 2351 -135
===========================================
+ Hits 11295 11766 +471
- Misses 3881 4105 +224
- Partials 516 551 +35 ☔ View full report in Codecov by Sentry. |
53c0e5c
to
4058ce8
Compare
# Flatcar images does automatic reboot without user input, so stopping the service which trigger the reboot | ||
# Broadcast message from locksmithd at 2024-02-23 19:48:55.478412272 +0000 UTC m= | ||
# System reboot in 5 minutes! | ||
systemctl stop locksmithd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's turn it off rather than stopping it (otherwise it'll just restart on the next boot)
Configuration
There are three different strategies that locksmithd can use after the update engine has successfully applied an update:
etcd-lock - reboot after first taking a lock in etcd.
reboot - reboot without taking a lock.
off - causes locksmithd to exit and do nothing.
These strategies will either be followed immediately after an update, or during the next available [reboot window](https://github.com/flatcar/locksmith#reboot-windows) if one has been configured.
These strategies can be configured via /etc/flatcar/update.conf with a line that looks like:
REBOOT_STRATEGY=reboot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this setting and its not effective until reboot. Maybe I need to check if service restart required.
* reset uphold settings for flatcar images * updated comment * stop the rebbot service * address comments (cherry picked from commit 5759501)
* reset uphold settings for flatcar images * updated comment * stop the rebbot service * address comments (cherry picked from commit 5759501) Co-authored-by: Nageswara Nandigam <84482346+nagworld9@users.noreply.github.com>
Description
New flatcar images set the uphold property for agent service that is causing automatic restart on stop cmd
[Upholds= dependency on it has a continuous effect, constantly restarting the unit if necessary]
Resetting the uphold property as workaround for now.
Issue #
PR information
Quality of Code and Contribution Guidelines