Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove secret and use cert for aad app in e2e pipeline #3116

Merged
merged 3 commits into from
May 7, 2024
Merged

remove secret and use cert for aad app in e2e pipeline #3116

merged 3 commits into from
May 7, 2024

Conversation

nagworld9
Copy link
Contributor

@nagworld9 nagworld9 commented May 1, 2024 •
edited
Loading

Description

Issue #

fixing Product Backlog Item 27486457: LMR: No Entra ID passwords anywhere - Security Sprint

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

maddieford
maddieford previously approved these changes May 2, 2024
View reviewed changes
narrieta
narrieta reviewed May 7, 2024
View reviewed changes
tests_e2e/pipeline/pipeline.yml Outdated
SecretsFilter: '*'

- task: AzureCLI@2
displayName: "Save connection certificate"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Download connection certificate"?

tests_e2e/pipeline/scripts/execute_tests.sh Show resolved Hide resolved
tests_e2e/pipeline/pipeline.yml Show resolved Hide resolved
@nagworld9 nagworld9 merged commit 6e5cde0 into Azure:develop May 7, 2024
11 checks passed
@nagworld9 nagworld9 deleted the appcert branch May 7, 2024 21:31
narrieta pushed a commit to narrieta/WALinuxAgent that referenced this pull request May 10, 2024
@nagworld9
remove secret and use cert for aad app in e2e pipeline (Azure#3116)
de3627b 
* remove secret and use cert

* address comment

(cherry picked from commit 6e5cde0)
narrieta added a commit that referenced this pull request May 10, 2024
@narrieta @nagworld9
remove secret and use cert for aad app in e2e pipeline (#3116) (#3125)
79414a7 
* remove secret and use cert

* address comment

(cherry picked from commit 6e5cde0)

Co-authored-by: Nageswara Nandigam <84482346+nagworld9@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narrieta narrieta narrieta approved these changes

@maddieford maddieford maddieford approved these changes

@ZhidongPeng ZhidongPeng Awaiting requested review from ZhidongPeng ZhidongPeng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nagworld9 @narrieta @maddieford