Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added retries for agent cgroups test #3075

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Conversation

nagworld9
Copy link
Contributor

Description

Sometimes test checks are happening before agent setup the cgroups, which causing test failures

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.63%. Comparing base (dd6c465) to head (f694ce6).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3075   +/-   ##
========================================
  Coverage    71.63%   71.63%           
========================================
  Files          110      110           
  Lines        16433    16433           
  Branches      2352     2352           
========================================
  Hits         11771    11771           
  Misses        4110     4110           
  Partials       552      552           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


return is_active and is_cgroup_assigned

if not retry_if_false(check_agent_service_cgroup):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add comments on why the retry is needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

@nagworld9 nagworld9 merged commit cc94d46 into Azure:develop Mar 1, 2024
13 checks passed
@nagworld9 nagworld9 deleted the cgroup-fixes branch March 1, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants