Switching to SNI based authentication for aad app #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagworld9
requested review from
narrieta,
ZhidongPeng and
maddieford
as code owners
nagworld9
commented
Jun 6, 2024
| @@ -67,7 +67,7 @@ RUN \ | |||
| cd $HOME && \ | |||
| git clone https://github.com/microsoft/lisa.git && \ | |||
| cd lisa && \ | |||
| git checkout 2c16e32001fdefb9572dff61241451b648259dbf && \ | |||
| git checkout 95c09ff7d5b6e71d1642a628607ac9bb441c69f5 && \ | |||
There was a problem hiding this comment.
Pulling lisa latest changes since they updated azure-identity version which supports SNI based authentication
| @@ -55,7 +55,7 @@ def add_security_rule(self, security_rule: Dict[str, Any]) -> None: | |||
| self._get_network_security_group()["properties"]["securityRules"].append(security_rule) | |||
|
|
|||
| def _get_network_security_group(self) -> Dict[str, Any]: | |||
| resources: List[Dict[str, Any]] = self._template["resources"] | |||
| resources: Dict[str, Dict[str, Any]] = self._template["resources"] | |||
There was a problem hiding this comment.
Schema updated in new lisa template; resources type changed to dict(dict) from list(dict)
maddieford
reviewed
Jun 6, 2024
maddieford
approved these changes
Jun 6, 2024
maddieford
pushed a commit
to maddieford/WALinuxAgent
that referenced
this pull request
Aug 13, 2024
* SNI auth * new env var * pylint (cherry picked from commit 81140ee)
maddieford
added a commit
that referenced
this pull request
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing security alert - removing pinned certs and switching to subject name issuer-based authentication
Issue #
PR information
Quality of Code and Contribution Guidelines